Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nz timestamp unit tests #8145

Merged

Conversation

NVnavkumar
Copy link
Collaborator

Fixes #7754.

Spark 3.4 actually removed the "heavier" "spark.sql.parquet.timestampNTZ.enabled configuration option (which prevented both inference and writing timestampNTZ with Parquet), and added the spark.sql.parquet.inferTimestampNTZ.enabled configuration option which only controls inference of the timestampNTZ type on reading Parquet (See apache/spark#39856)

This PR fixes the configuration so the unit test passes.

…er inferTimestampNTZ config

Signed-off-by: Navin Kumar <[email protected]>
@NVnavkumar NVnavkumar requested a review from andygrove April 19, 2023 03:40
@NVnavkumar NVnavkumar self-assigned this Apr 19, 2023
@NVnavkumar
Copy link
Collaborator Author

build

@sameerz sameerz added the Spark 3.4+ Spark 3.4+ issues label Apr 19, 2023
Copy link
Collaborator

@revans2 revans2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The config was added in 3.4 and changed in 3.4 so no need to maintain compatibility with both configs.

@NVnavkumar NVnavkumar merged commit f2cfde0 into NVIDIA:branch-23.06 Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Spark 3.4+ Spark 3.4+ issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] unit test nz timestamp fails on Spark-3.4
3 participants