Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] the jar with scaladoc overwrites the jar with javadoc #8440

Closed
gerashegalov opened this issue May 31, 2023 · 0 comments · Fixed by #8464
Closed

[BUG] the jar with scaladoc overwrites the jar with javadoc #8440

gerashegalov opened this issue May 31, 2023 · 0 comments · Fixed by #8464
Assignees
@gerashegalov
Labels
bug Something isn't working build Related to CI / CD or cleanly building

Comments

@gerashegalov
Copy link
Collaborator

Describe the bug

The source-javadoc profile generates a javadoc jar using the javadoc plugin in the default package phase

Later the javadoc jar is replaced when the Scala plugin's doc-jar goal is executed in the verify phase. This is because it also uses the javadoc classifier.

Thus the resulting published jar https://repo1.maven.org/maven2/com/nvidia/rapids-4-spark_2.12/23.04.1/rapids-4-spark_2.12-23.04.1-javadoc.jar has no javadoc output

Steps/Code to reproduce bug

mvn -P source-javadoc -Dbuildver=311 -DskipTests clean install -pl aggregator -am

Expected behavior

Options

Environment details (please complete the following information)

  • any

Additional context

noticed javadoc generates warnings but actually not "needed" with the current build.
@gerashegalov gerashegalov added bug Something isn't working ? - Needs Triage Need team to review and classify build Related to CI / CD or cleanly building labels May 31, 2023
@gerashegalov gerashegalov changed the title [BUG] the jar with scaladoc overwrites jar with javadoc [BUG] the jar with scaladoc overwrites the jar with javadoc May 31, 2023
@gerashegalov gerashegalov self-assigned this Jun 1, 2023
@gerashegalov gerashegalov removed the ? - Needs Triage Need team to review and classify label Jun 1, 2023
gerashegalov added a commit to gerashegalov/spark-rapids that referenced this issue Jun 1, 2023
@gerashegalov
Remove NOP javadoc plugin
695f787 
Fixes NVIDIA#8440

Signed-off-by: Gera Shegalov <[email protected]>
@gerashegalov gerashegalov mentioned this issue Jun 1, 2023
Merged
gerashegalov added a commit that referenced this issue Jun 1, 2023
@gerashegalov
Remove NOP Maven javadoc plugin definition (#8464)
010ab7d 
Fixes #8440

Java classes are processed by doc-jar in scala-maven-plugin as we leave the default `sendJavaToScalac=true` unchanged

```bash
$ find sql-plugin/  -regex '.*/GpuPackedTableColumn.\(java\|html\|class\)'
sql-plugin/target/spark311/site/scaladocs/com/nvidia/spark/rapids/GpuPackedTableColumn.html
sql-plugin/target/spark311/classes/com/nvidia/spark/rapids/GpuPackedTableColumn.class
sql-plugin/src/main/java/com/nvidia/spark/rapids/GpuPackedTableColumn.jav
```
     
Signed-off-by: Gera Shegalov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gerashegalov gerashegalov

Labels
bug Something isn't working build Related to CI / CD or cleanly building
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove NOP Maven javadoc plugin definition gerashegalov/spark-rapids
1 participant
@gerashegalov