Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Qwen-2.5 Notebook #496

Merged
merged 2 commits into from
Feb 19, 2025
Merged

Add Qwen-2.5 Notebook #496

merged 2 commits into from
Feb 19, 2025

Conversation

rishic3
Copy link
Collaborator

@rishic3 rishic3 commented Feb 16, 2025

Adding Qwen notebook, mainly to demonstrate how to leverage system prompts/chat templates for batch inference. Also serves as a non-gated and faster alternative to Gemma.

Signed-off-by: Rishi Chandra <[email protected]>
@rishic3 rishic3 marked this pull request as ready for review February 18, 2025 16:31
@rishic3 rishic3 requested a review from eordentlich February 18, 2025 20:00
Copy link
Collaborator

@eordentlich eordentlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Just one minor question/suggestion.

"metadata": {},
"outputs": [],
"source": [
"def preprocess(text: pd.Series, system_prompt: str) -> pd.Series:\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is just sting substitution/concatenation, wonder if worth demoing a Spark SQL way to do it as more Spark native.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done; good suggestion

Copy link
Collaborator

@eordentlich eordentlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rishic3 rishic3 merged commit 3ed95bd into NVIDIA:branch-25.02 Feb 19, 2025
3 checks passed
@rishic3 rishic3 deleted the qwen-demo branch February 19, 2025 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants