Implement and use TritonServerManager class #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rishi Chandra <[email protected]>
eordentlich
reviewed
Feb 6, 2025
| return None | ||
| return f"grpc://localhost:{self._ports[1]}" | ||
|
|
||
| def _find_ports(self, start_port: int = 7000) -> List[int]: |
There was a problem hiding this comment.
Thinking about this again, should port finding be integrated into server start spark job which would return the ports and pids? Otherwise, likelier that ports could be taken in the mean time.
eordentlich
reviewed
Feb 7, 2025
examples/ML+DL-Examples/Spark-DL/dl_inference/pytriton_utils.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidate util functions into a server manager class to simplify usage. (Note that notebooks were rerun but only the Triton utility invocations are changed).
Also on Dataproc, the utils file needs to be copied driver root dir instead of the same directory as the notebooks, since sc.addPyFile on Dataproc only accepts absolute paths from root.