Skip to content

Build script option to change raft active/logging level - #3061

Merged
rapids-bot[bot] merged 4 commits into
NVIDIA:mainfrom
huuanhhuyn:raft_active_level
Jun 29, 2026
Merged

Build script option to change raft active/logging level#3061
rapids-bot[bot] merged 4 commits into
NVIDIA:mainfrom
huuanhhuyn:raft_active_level

Conversation

@huuanhhuyn

@huuanhhuyn huuanhhuyn commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Add option in build.sh to change RAFT_LOG_ACTIVE_LEVEL

@copy-pr-bot

copy-pr-bot Bot commented Jun 26, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@aamijar aamijar added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Jun 26, 2026
@aamijar
aamijar requested a review from a team as a code owner June 26, 2026 21:39
@aamijar

aamijar commented Jun 26, 2026

Copy link
Copy Markdown
Member

/ok to test ffc19fc

@aamijar

aamijar commented Jun 26, 2026

Copy link
Copy Markdown
Member

Hello @huuanhhuyn, thanks for your contributions! Please remember to run pre-commit so that the CI job check-style will pass. Already did it for your PR so you don't need to do anything for this one.

@aamijar

aamijar commented Jun 26, 2026

Copy link
Copy Markdown
Member

/ok to test 251cb4a

@aamijar

aamijar commented Jun 27, 2026

Copy link
Copy Markdown
Member

/ok to test be82dee

@huuanhhuyn

huuanhhuyn commented Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

Thanks @aamijar for fixing pre-commit checks and triggering the tests!
@gforsyth This PR stills have a pending review from NVIDIA/adi-packaging-codeowners after you have approved it. Could you please tell me what is missing?

@huuanhhuyn

Copy link
Copy Markdown
Contributor Author

/merge

@tfeher tfeher left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Huy!

@cjnolet

cjnolet commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

@huuanhhuynn the repos have been moved to NVIDIA org, which means someone from Adi-packaging-codeowners (formerly packaging-codeowners) needs to approve it. I believe @gforsyth should be able to re-approve.

@aamijar

aamijar commented Jun 29, 2026

Copy link
Copy Markdown
Member

/merge

@rapids-bot
rapids-bot Bot merged commit 6a0f7b3 into NVIDIA:main Jun 29, 2026
79 checks passed
@huuanhhuyn
huuanhhuyn deleted the raft_active_level branch June 30, 2026 07:24
rapids-bot Bot pushed a commit to NVIDIA/cuvs that referenced this pull request Jul 10, 2026
Allow user to change `RAFT_LOG_ACTIVE_LEVEL` when building cuvs:
`build.sh libcuvs --logging-level <level>`

Follows up NVIDIA/raft#3061

Authors:
  - https://github.com/huuanhhuyn

Approvers:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

URL: #2276
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants