Fix symbol export - #3006
Merged
Merged
Conversation
vyasr
added
improvement
robertmaynard
previously requested changes
Apr 29, 2026
robertmaynard
left a comment
robertmaynard
left a comment
Contributor
There was a problem hiding this comment.
I expect we need all installed RAFT headers to have the markup of RAFT_EXPORT otherwise you can't pass a raft handle from a library that use raft into raft itself.
csadorf
reviewed
Apr 30, 2026
| #include <raft/util/vectorized.cuh> | ||
|
|
||
| namespace raft::detail { | ||
| namespace RAFT_EXPORT raft { |
Contributor
There was a problem hiding this comment.
Technically the raft::detail namespace is not considered part of the public API. I think we should roll this out in stages though and maybe drop that in a follow-up to minimize discruption.
Remove the separate _FUNCTION macro variants since RAFT_EXPORT can be used directly on function declarations. Update raft_runtime headers to use RAFT_EXPORT instead of the removed RAFT_EXPORT_FUNCTION.
vyasr
force-pushed
the
fix/symbol_export
branch
from
April 30, 2026 22:15
b30e484 to
0942b42
Compare
divyegala
approved these changes
May 8, 2026
Contributor
Author
|
/merge |
This was referenced May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds symbol visibility controls to raft to avoid exporting weak symbols that it shouldn't.
Contributes to https://github.com/rapidsai/build-infra/issues/53