[FIX] Always add faiss library alias if it's missing - #287
Merged
Conversation
cjnolet
added
3 - Ready for Review
improvement
Member
Author
|
rerun tests |
Member
Author
|
rerun tests |
dantegd
approved these changes
Jul 9, 2021
Contributor
|
@gpucibot merge |
loulankxh
pushed a commit
to loulankxh/raft
that referenced
this pull request
Oct 14, 2025
Always add the `FAISS::FAISS` library target alias if it doesn't exist. This can happen if cuML is built and installs FAISS before cuGraph or vice-versa. Related PRs: NVIDIA/cuml#4028 rapidsai/cugraph#1694 Note: We can probably remove the `get_faiss.cmake` file in cuML and cuGraph since they both should get it from RAFT. Authors: - Paul Taylor (https://github.com/trxcllnt) Approvers: - Corey J. Nolet (https://github.com/cjnolet) - Dante Gama Dessavre (https://github.com/dantegd) URL: NVIDIA#287
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Always add the
FAISS::FAISSlibrary target alias if it doesn't exist. This can happen if cuML is built and installs FAISS before cuGraph or vice-versa.Related PRs:
NVIDIA/cuml#4028
rapidsai/cugraph#1694
Note: We can probably remove the
get_faiss.cmakefile in cuML and cuGraph since they both should get it from RAFT.