Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 17 additions & 6 deletions deploy/helm/vanity-gateway/AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Native Helm chart subtree. Shared chart rules live in `deploy/helm/AGENTS.md`.
- Chart directory: `helm-nvcf-vanity-gateway`
- CI values: `tools/ci/helm-validate-values/vanity-gateway.yaml`
- Release service name: `helm-nvcf-vanity-gateway`
- Initial release version: not yet assigned. See "Versioning" below.
- Release tag format: `deploy/helm/vanity-gateway/v<X.Y.Z>`

## Provenance

Expand All @@ -22,11 +22,22 @@ to match the other chart subtrees.

## Versioning

The imported `Chart.yaml` still carries the published version
`0.1.0-nvcf-10204.1` and appVersion `1.25.0-nvcf-10204.0`. Neither is a form the
repo release tooling accepts, so no release lane is registered for this chart
and no tag exists. Renumber `version` to a plain `X.Y.Z` before wiring a
release lane.
The chart is registered in `tools/ci/github-release-subprojects.json` with an
`initial_version` floor of `0.2.0`, so it releases on tags of the form
`deploy/helm/vanity-gateway/v<X.Y.Z>`. The release job creates
`deploy/helm/vanity-gateway/v0.2.0` in its own checkout as a semantic-release
baseline and never pushes it, so `0.2.0` is not a published chart version. The
first published version is `0.3.0` for a `feat` commit under this subtree, or
`0.2.1` for a `fix`. The
floor sits above the `0.1.0-nvcf-10204.x` artifacts the chart was recovered
from, so every published version is unambiguously newer. See
`docs/dev/github-release-process.md`.

`Chart.yaml` carries `version: 0.0.0`. The release pipeline packages the chart
at the version taken from the release tag, so the committed value is only used
by local renders and never ships.

`appVersion` tracks the image this chart deploys and is bumped by hand.

## Validate

Expand Down
6 changes: 3 additions & 3 deletions deploy/helm/vanity-gateway/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -118,9 +118,9 @@ bounds concurrent shadow requests across all routes.

## Notes

- The chart version and appVersion carry the versions of the published artifact
this chart was recovered from. They are not in a form the repo release tooling
accepts, and no release lane is registered. See `AGENTS.md`.
- The chart version is `0.0.0` in `Chart.yaml`. The release pipeline packages
the chart at the version in its `deploy/helm/vanity-gateway/v<X.Y.Z>` release
tag, so the committed value only affects local renders. See `AGENTS.md`.
- If you publish or mirror the required images into another registry, set the
image registry, repository, tag, and pull secret values explicitly in your
override file.
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ appVersion: 1.32.1
description: Helm chart for the NVCF Vanity Gateway
name: helm-nvcf-vanity-gateway
type: application
version: 0.1.0-nvcf-10204.1
version: 0.0.0 # autoversioning enabled via release pipeline
6 changes: 6 additions & 0 deletions tools/ci/github-release-subprojects.json
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,12 @@
"service_name": "nvcf-gateway-routes",
"legacy_tag_prefix": "nvcf-gateway-routes-v"
},
{
"id": "vanity-gateway-helm",
"path": "deploy/helm/vanity-gateway",
"service_name": "helm-nvcf-vanity-gateway",
"initial_version": "0.2.0"
},
{
"id": "nvca-operator",
"path": "deploy/helm/nvca-operator",
Expand Down
Loading