-
Notifications
You must be signed in to change notification settings - Fork 49
feat(event-ledger): add event-ledger release to self-managed stack #803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
shelleyshen-0
wants to merge
2
commits into
main
Choose a base branch
from
feat/event-ledger-stack-integration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+24
−0
Draft
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win
Add repeatable validation for the new release.
This change adds a Helmfile release and changes the default environment. Add a repository-native render or lint test that checks the condition, chart version, namespace, and image values, or explain in the Pull Request why tests are not applicable. Run the repository-native test runner before committing.
As per coding guidelines: “Code changes must include tests, or the Pull Request must explain why tests are not applicable; run the repository-native test runner before committing.”
🤖 Prompt for AI Agents
Source: Coding guidelines
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
Repository: NVIDIA/nvcf
Length of output: 17203
🏁 Script executed:
Repository: NVIDIA/nvcf
Length of output: 32883
🌐 Web query:
NVIDIA nvcf helm-event-ledger 0.1.0-test chart💡 Result:
The NVIDIA Cloud Functions (NVCF) platform maintains an internal component referred to as the Event Ledger [1]. Recent technical documentation and development activity indicate that the Event Ledger is an internal service within the NVCF control plane ecosystem, currently undergoing refactoring to decouple it from proprietary authorization services [1]. While there are numerous documented Helm charts for the NVCF self-hosted stack (e.g., helm-nvcf-api, helm-nvcf-nats, helm-nvcf-invocation-service) [2][3][4], there is no public-facing, standalone "nvcf helm-event-ledger 0.1.0-test" chart listed in the official NVCF manifest or the NGC catalog [2][5]. The Event Ledger is integrated into the broader NVCF control plane architecture rather than being distributed as a standalone, versioned test chart for general public use [1][3]. Development efforts, such as PR
#256in the NVIDIA/nvcf repository, focus on adding public Go interfaces (e.g., Authorizer) to allow the Event Ledger to function with pluggable identity providers, specifically to support open-source builds [1]. You may find related logic within the nvcf source code repository, but it is not provided as an independent Helm chart with the specified version [1][6].Citations:
🏁 Script executed:
Repository: NVIDIA/nvcf
Length of output: 2469
🏁 Script executed:
Repository: NVIDIA/nvcf
Length of output: 739
🏁 Script executed:
Repository: NVIDIA/nvcf
Length of output: 357
Do not enable
event-ledgerin the default environment.base.yamlenablesaddons.eventLedger.enabled, so the default installation selectsnvcf/helm-event-ledger:0.1.0-test. If the configured chart source does not contain this unreleased version, Helmfile cannot resolve the chart and installation fails. Disable the addon in the base environment until an officially published chart version is available.🤖 Prompt for AI Agents