Skip to content

Replace localstack with ministack #796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nahuel990 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Replace localstack with ministack #796

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/control-plane-services/cloud-functions/local_env/docker-compose.test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ name: nvcf-cloud-functions-test

services:
aws:
image: localstack/localstack:4.3
image: ministackorg/ministack:1.4.16

@coderabbitai coderabbitai Bot Aug 12, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔒 Security & Privacy | 🟡 Minor | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/usr/bin/env bash
set -euo pipefail

image='ministackorg/ministack:1.4.16'

docker buildx imagetools inspect "$image"

test -f .allowed-licenses.txt
rg -n -i '\bMIT\b|ministack' .allowed-licenses.txt

fd -HI -t f '^(NOTICE|NOTICE\..*|THIRD_PARTY.*)$' .

Repository: NVIDIA/nvcf

Length of output: 193

Use one immutable and approved MiniStack image reference in all four Compose files.

Resolve the multi-platform manifest digest for ministackorg/ministack:1.4.16, use the same digest in all four Compose files, and verify the license against .allowed-licenses.txt. Add the required NOTICE or attribution entry if applicable.

📍 Affects 4 files
  • src/control-plane-services/cloud-functions/local_env/docker-compose.test.yml#L21-L21 (this comment)
  • src/control-plane-services/cloud-functions/local_env/docker-compose.yml#L21-L21
  • src/control-plane-services/instance-cluster-management/local_env/docker-compose.test.yml#L21-L21
  • src/control-plane-services/instance-cluster-management/local_env/docker-compose.yml#L42-L42
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/control-plane-services/cloud-functions/local_env/docker-compose.test.yml`
at line 21, Replace the MiniStack tag with the resolved multi-platform manifest
digest for ministackorg/ministack:1.4.16 in all four Compose files:
src/control-plane-services/cloud-functions/local_env/docker-compose.test.yml:21-21,
src/control-plane-services/cloud-functions/local_env/docker-compose.yml:21-21,
src/control-plane-services/instance-cluster-management/local_env/docker-compose.test.yml:21-21,
and
src/control-plane-services/instance-cluster-management/local_env/docker-compose.yml:42-42.
Use the identical immutable digest everywhere, verify its license against
.allowed-licenses.txt, and add the required NOTICE or attribution entry if
applicable.

Sources: Coding guidelines, MCP tools

environment:
- SERVICES=sts,s3
- AWS_DEFAULT_REGION=us-east-1
Expand Down
2 changes: 1 addition & 1 deletion src/control-plane-services/cloud-functions/local_env/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ name: nvcf-cloud-functions-local

services:
aws:
image: localstack/localstack:4.3
image: ministackorg/ministack:1.4.16
environment:
- SERVICES=sts,s3
- AWS_DEFAULT_REGION=us-east-1
Expand Down
2 changes: 1 addition & 1 deletion src/control-plane-services/instance-cluster-management/local_env/docker-compose.test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ name: icms-test

services:
aws:
image: localstack/localstack:4.3
image: ministackorg/ministack:1.4.16
environment:
- SERVICES=sqs,sns,sts
- DEFAULT_REGION=us-east-1
Expand Down
2 changes: 1 addition & 1 deletion src/control-plane-services/instance-cluster-management/local_env/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ services:
chmod +x /entrypoint.sh
nohup /entrypoint.sh & cassandra -f -R
aws:
image: localstack/localstack:4.3
image: ministackorg/ministack:1.4.16
environment:
- SERVICES=sqs,sns,sts
- DEFAULT_REGION=us-east-1
Expand Down