-
Notifications
You must be signed in to change notification settings - Fork 49
docs(byoo): document upstream telemetry compatibility #763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sbaum1994
wants to merge
2
commits into
main
Choose a base branch
from
docs/byoo-upstream-metric-semantics-705
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+69
−0
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
67 changes: 67 additions & 0 deletions
67
docs/user/cluster-management/byoo-telemetry-compatibility.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| # BYOO Telemetry Compatibility | ||
|
|
||
| ## Summary | ||
|
|
||
| NVIDIA Cloud Functions (NVCF) Bring Your Own Observability (BYOO) uses | ||
| telemetry from upstream components such as the OpenTelemetry Collector and | ||
| cAdvisor. Their output changes over time as those projects move forward. We | ||
| preserve valid upstream telemetry instead of rewriting new output to look like | ||
| an earlier version. This keeps the telemetry true to its source, but a valid | ||
| upgrade can require changes to dashboards, alerts, or automation. | ||
|
|
||
| The upstream components are the source of truth for metric semantics. Our | ||
| generated metric references and validation fixtures follow that output. | ||
|
|
||
| ## Key decisions | ||
|
|
||
| 1. We preserve valid upstream metric names, types, labels, label values, and | ||
| histogram buckets. | ||
| 1. We do not rename, filter, or modify a valid metric only to retain an earlier | ||
| NVCF output shape. | ||
| 1. We transform upstream telemetry only when we have a documented user-facing | ||
| reason. | ||
| 1. We update generated metric references and validation fixtures after we | ||
| verify an upstream behavior change. | ||
|
|
||
| This policy does not prevent documented filters that limit telemetry to an | ||
| NVCF workload, remove sensitive metadata, or apply a customer-configured metric | ||
| subset. It prevents compatibility rules that hide valid upstream changes only | ||
| to make new output match an old validation baseline. | ||
|
|
||
| ## What changes during upgrades | ||
|
|
||
| Review dashboards, alerts, recording rules, and automation when the BYOO | ||
| OpenTelemetry Collector version changes. A valid upstream change can require | ||
| updates even when telemetry collection continues to work. | ||
|
|
||
| For example, an OpenTelemetry Collector release exposed some `otelcol_*` | ||
| counter metrics without the `_total` suffix used by an earlier version. We keep | ||
| the names emitted by the collector instead of adding the suffix back. | ||
|
|
||
| cAdvisor also emits pod-sandbox metrics with the label `container="POD"`. | ||
| These are valid upstream series and can provide pod network, CPU, and memory | ||
| telemetry. We keep these series instead of dropping them because the | ||
| container label does not name an application container. | ||
|
|
||
| ## How we validate changes | ||
|
|
||
| We use generated metric references and golden fixtures to catch differences in | ||
| observed telemetry. These checks tell us that the output changed. They do not | ||
| make an older fixture the permanent telemetry contract. | ||
|
|
||
| When an upstream component changes its telemetry, maintainers: | ||
|
|
||
| 1. Verify the observed metric against the upstream component behavior. | ||
| 1. Confirm that the metric is valid and belongs to the supported BYOO scope. | ||
| 1. Update generated metric references and golden fixtures to the new output. | ||
| 1. Add a transformation only when a documented user-facing requirement needs | ||
| one. | ||
|
|
||
| Do not ignore a valid metric, alias its name, synthesize labels, or rewrite | ||
| label values only to make it pass an older fixture. Document any intentional | ||
| transformation and its user-visible reason. | ||
|
|
||
| ## Further reading | ||
|
|
||
| For BYOO collector options, refer to | ||
| [NVCA Configuration](./configuration.md#agent-config-merging). | ||
|
Comment on lines
+66
to
+67
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win Correct the configuration link label.
🤖 Prompt for AI Agents |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this paragraph