Repository navigation
feat(llm-api-gateway): expose GET /info endpoint #710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
d11e60f
feat(llm-api-gateway): expose GET /info endpoint
priyaselvaganesan d24ab5f
test(llm-api-gateway): use direct var mutation for /info exact-value …
priyaselvaganesan f751a86
chore(llm-api-gateway): align otel exporter versions with core v1.44.0
priyaselvaganesan 247f353
test(llm-api-gateway): add fallback test and CONNECT/TRACE method cov…
priyaselvaganesan c176d87
test(llm-api-gateway): isolate fallback test from version globals
priyaselvaganesan 25c5971
fix(llm-api-gateway): register GET /info explicitly with e.Match 405 …
priyaselvaganesan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
90 changes: 90 additions & 0 deletions
90
src/invocation-plane-services/llm-api-gateway/api/info_test.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,90 @@ | ||
| /* | ||
| SPDX-FileCopyrightText: Copyright (c) NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package api | ||
|
|
||
| import ( | ||
| "encoding/json" | ||
| "net/http" | ||
| "net/http/httptest" | ||
| "testing" | ||
|
|
||
| echo "github.com/labstack/echo/v4" | ||
|
|
||
| "github.com/NVIDIA/nvcf/src/invocation-plane-services/llm-gateway/config" | ||
| ) | ||
|
|
||
| // newInfoEngine builds an echo engine with the service routes registered so the | ||
| // /info endpoint can be exercised the same way it is served at runtime. | ||
| func newInfoEngine() *echo.Echo { | ||
| e := echo.New() | ||
| RegisterRoutes(e, NewHandlers(config.Default(), nil, nil)) | ||
| return e | ||
| } | ||
|
|
||
| func TestInfoEndpoint_GET(t *testing.T) { | ||
| t.Parallel() | ||
|
|
||
| e := newInfoEngine() | ||
|
|
||
| rec := httptest.NewRecorder() | ||
| req := httptest.NewRequest(http.MethodGet, "/info", nil) | ||
| e.ServeHTTP(rec, req) | ||
|
|
||
| if rec.Code != http.StatusOK { | ||
| t.Fatalf("GET /info: got status %d, want %d", rec.Code, http.StatusOK) | ||
| } | ||
| if ct := rec.Header().Get("Content-Type"); ct != "application/json" { | ||
| t.Errorf("GET /info: got Content-Type %q, want application/json", ct) | ||
| } | ||
|
|
||
| // x_defs are not injected under `go test`; resolve() falls back to "unknown" | ||
| // for any empty field, so all three values are guaranteed non-empty. | ||
| var info map[string]string | ||
| if err := json.Unmarshal(rec.Body.Bytes(), &info); err != nil { | ||
| t.Fatalf("GET /info: unmarshal body: %v", err) | ||
| } | ||
| for _, field := range []string{"service", "version", "commit"} { | ||
| if info[field] == "" { | ||
| t.Errorf("GET /info: field %q must be populated", field) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| func TestInfoEndpoint_RejectsNonGET(t *testing.T) { | ||
| t.Parallel() | ||
|
|
||
| e := newInfoEngine() | ||
|
|
||
| for _, method := range []string{http.MethodPost, http.MethodPut, http.MethodDelete} { | ||
| t.Run(method, func(t *testing.T) { | ||
| rec := httptest.NewRecorder() | ||
| req := httptest.NewRequest(method, "/info", nil) | ||
| e.ServeHTTP(rec, req) | ||
|
|
||
| if rec.Code != http.StatusMethodNotAllowed { | ||
| t.Errorf("%s /info: got status %d, want %d", method, rec.Code, http.StatusMethodNotAllowed) | ||
| } | ||
| if allow := rec.Header().Get("Allow"); allow != http.MethodGet { | ||
| t.Errorf("%s /info: got Allow %q, want %q", method, allow, http.MethodGet) | ||
| } | ||
| if body := rec.Body.String(); body != "" { | ||
| t.Errorf("%s /info: got non-empty body %q", method, body) | ||
| } | ||
| }) | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.