feat(nvca): add OTel semconv metrics for outbound dependency clients (3.1) - #685
Merged
rohithb-hub merged 2 commits intoAug 5, 2026
Conversation
Signed-off-by: rohithb <rohithb@nvidia.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
vrv3814
approved these changes
Aug 5, 2026
rohithb-hub
merged commit Aug 5, 2026
fd5d68a
into
release-src/compute-plane-services/nvca/v3.1
31 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Backport of #583 to the NVCA 3.1 release line. Cherry-picks the squash-merged
mainline commit onto
release-src/compute-plane-services/nvca/v3.1.Additional Details
Instruments NVCA outbound dependency calls with OpenTelemetry Semantic Conventions
metrics bridged to the existing Prometheus
/metricsendpoint. Everything is gatedby the
ClientMetricsfeature flag, off by default, so this is a no-op on 3.1unless the flag is explicitly enabled.
Cherry-pick applied with one conflict: the root
MODULE.bazeluse_repolinediffered because main has accumulated unrelated Bazel deps since 3.1 branched. The
3.1 version was kept — it already contains all the OTel Bazel entries this commit
needs (
io_opentelemetry_go_otel_exporters_prometheus,io_opentelemetry_go_otel_sdk_metric).All source and vendor changes applied without conflict.
For the Reviewer
Compare this diff with #583. The only intentional deviation from the mainline commit
is the
MODULE.bazeluse_repoline, which retains the 3.1 state rather thanpulling in unrelated main-branch Bazel deps.
For QA
No QA needed. The
ClientMetricsflag is off by default. With it off the pipelineinstalls a no-op meter provider and all decorators return the inner client unchanged,
identical to the behaviour before this change.
Ran focused Go tests on the 3.1 branch:
Issues
NO-REF
Backport of #583
Checklist