Skip to content

feat(nvca): add OTel semconv metrics for outbound dependency clients (3.1) - #685

Merged
rohithb-hub merged 2 commits into
release-src/compute-plane-services/nvca/v3.1from
fix/nvca-otel-client-metrics-backport-v3.1
Aug 5, 2026
Merged

feat(nvca): add OTel semconv metrics for outbound dependency clients (3.1)#685
rohithb-hub merged 2 commits into
release-src/compute-plane-services/nvca/v3.1from
fix/nvca-otel-client-metrics-backport-v3.1

Conversation

@rohithb-hub

Copy link
Copy Markdown
Contributor

TL;DR

Backport of #583 to the NVCA 3.1 release line. Cherry-picks the squash-merged
mainline commit onto release-src/compute-plane-services/nvca/v3.1.

Additional Details

Instruments NVCA outbound dependency calls with OpenTelemetry Semantic Conventions
metrics bridged to the existing Prometheus /metrics endpoint. Everything is gated
by the ClientMetrics feature flag, off by default, so this is a no-op on 3.1
unless the flag is explicitly enabled.

Cherry-pick applied with one conflict: the root MODULE.bazel use_repo line
differed because main has accumulated unrelated Bazel deps since 3.1 branched. The
3.1 version was kept — it already contains all the OTel Bazel entries this commit
needs (io_opentelemetry_go_otel_exporters_prometheus, io_opentelemetry_go_otel_sdk_metric).
All source and vendor changes applied without conflict.

For the Reviewer

Compare this diff with #583. The only intentional deviation from the mainline commit
is the MODULE.bazel use_repo line, which retains the 3.1 state rather than
pulling in unrelated main-branch Bazel deps.

For QA

No QA needed. The ClientMetrics flag is off by default. With it off the pipeline
installs a no-op meter provider and all decorators return the inner client unchanged,
identical to the behaviour before this change.

Ran focused Go tests on the 3.1 branch:

go test ./internal/metrics/... ./internal/otel/... ./pkg/nvca/... \
  -ldflags '-X github.com/NVIDIA/k8s-dra-driver-gpu/internal/info.version=v25.8.0' \
  -count=1

Issues

NO-REF

Backport of #583

Checklist

  • I am familiar with the Contributing Guidelines.
  • I have signed off my commits for Developer Certificate of Origin (DCO) compliance.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@rohithb-hub
rohithb-hub requested review from a team as code owners August 5, 2026 10:59
@rohithb-hub
rohithb-hub requested a review from balajinvda August 5, 2026 10:59
@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)
  • main

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: d6accf7e-fee5-4393-b643-5fcb63c0fa47

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@rohithb-hub
rohithb-hub merged commit fd5d68a into release-src/compute-plane-services/nvca/v3.1 Aug 5, 2026
31 checks passed
@rohithb-hub
rohithb-hub deleted the fix/nvca-otel-client-metrics-backport-v3.1 branch August 5, 2026 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants