fix(function-autoscaler): restore multi-arch OpenSSL paths - #674
Conversation
Signed-off-by: Bora Oztekin <boztekin@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe Bazel module adds an ChangesOpenSSL crate configuration
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@MODULE.bazel`:
- Around line 232-239: Update the OpenSSL environment configuration in the
supported-targets section to define target-specific include and library
directory variables for both x86_64-apple-darwin and aarch64-apple-darwin,
rather than allowing them to inherit Linux paths; alternatively remove those
macOS triples from SUPPORTED_TRIPLES if they are not supported.
- Around line 232-239: The OpenSSL configuration in the Bazel environment uses
the x86_64 library path for aarch64 builds, making openssl-sys non-hermetic.
Update the aarch64-specific settings in MODULE.bazel to reference Bazel-managed
arm64 OpenSSL headers and libraries, including the required per-platform inputs;
alternatively remove aarch64-unknown-linux-gnu from SUPPORTED_TRIPLES until that
toolchain support exists.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: dcb43f31-9d69-4bad-8f1a-43e8ac6a5138
📒 Files selected for processing (1)
MODULE.bazel
Signed-off-by: Bora Oztekin <boztekin@nvidia.com>
Signed-off-by: Bora Oztekin <boztekin@nvidia.com>
TL;DR
Restore the target-specific OpenSSL paths dropped during the root Bazel module
consolidation, unblocking the function-autoscaler ARM64 image build.
Additional Details
#533 configured
openssl-sysfor both AMD64 and ARM64. When #593 moved theautoscaler into the root Bazel module, that
crate.annotationwas nottransferred.
The omission caused the manual image push to fail because
AARCH64_UNKNOWN_LINUX_GNU_OPENSSL_LIB_DIRwas unset:https://github.com/NVIDIA/nvcf/actions/runs/30954727158
This restores the previous configuration without changing service code,
dependencies, or lockfiles.
For the Reviewer
Please verify the restored annotation in
MODULE.bazelmatches the Bazel CIimage’s AMD64 and ARM64 OpenSSL paths.
For QA
git diff --checkpassed.ARM64 OpenSSL sysroot.
Issues
Relates to #527
Checklist
Summary by CodeRabbit