Skip to content

fix(function-autoscaler): restore multi-arch OpenSSL paths - #674

Merged
borao merged 3 commits into
mainfrom
fix/function-autoscaler/restore-multi-arch-build
Aug 6, 2026
Merged

fix(function-autoscaler): restore multi-arch OpenSSL paths#674
borao merged 3 commits into
mainfrom
fix/function-autoscaler/restore-multi-arch-build

Conversation

@borao

@borao borao commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

TL;DR

Restore the target-specific OpenSSL paths dropped during the root Bazel module
consolidation, unblocking the function-autoscaler ARM64 image build.

Additional Details

#533 configured openssl-sys for both AMD64 and ARM64. When #593 moved the
autoscaler into the root Bazel module, that crate.annotation was not
transferred.

The omission caused the manual image push to fail because
AARCH64_UNKNOWN_LINUX_GNU_OPENSSL_LIB_DIR was unset:

https://github.com/NVIDIA/nvcf/actions/runs/30954727158

This restores the previous configuration without changing service code,
dependencies, or lockfiles.

For the Reviewer

Please verify the restored annotation in MODULE.bazel matches the Bazel CI
image’s AMD64 and ARM64 OpenSSL paths.

For QA

  • git diff --check passed.
  • The image build was not run locally because this host lacks Bazel and the
    ARM64 OpenSSL sysroot.
  • Validate with the manual image-push workflow against this branch.

Issues

Relates to #527

Checklist

  • I am familiar with the Contributing Guidelines.
  • I have signed off my commits for Developer Certificate of Origin (DCO) compliance.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Summary by CodeRabbit

  • Chores
    • Improved build configuration for autoscaler components across supported architectures.
    • Standardized OpenSSL integration to use architecture-specific system libraries and headers.

Signed-off-by: Bora Oztekin <boztekin@nvidia.com>
@borao
borao requested a review from a team as a code owner August 4, 2026 22:27
@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 5e13a589-00f6-4ddd-90f1-82b9fa2d5589

📥 Commits

Reviewing files that changed from the base of the PR and between ce5b7cf and 640525d.

📒 Files selected for processing (1)
  • MODULE.bazel
🚧 Files skipped from review as they are similar to previous changes (1)
  • MODULE.bazel

📝 Walkthrough

Walkthrough

The Bazel module adds an openssl-sys crate annotation. The annotation configures native OpenSSL paths, aarch64 compiler include flags, and disables vendored OpenSSL builds.

Changes

OpenSSL crate configuration

Layer / File(s) Summary
Native OpenSSL annotation
MODULE.bazel
Adds architecture-specific OpenSSL include and library paths, aarch64 compiler flags, and OPENSSL_NO_VENDOR for openssl-sys.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: sparve-nv

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title uses the required Conventional Commits format and accurately describes the OpenSSL path restoration that fixes multi-architecture autoscaler builds.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/function-autoscaler/restore-multi-arch-build

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@MODULE.bazel`:
- Around line 232-239: Update the OpenSSL environment configuration in the
supported-targets section to define target-specific include and library
directory variables for both x86_64-apple-darwin and aarch64-apple-darwin,
rather than allowing them to inherit Linux paths; alternatively remove those
macOS triples from SUPPORTED_TRIPLES if they are not supported.
- Around line 232-239: The OpenSSL configuration in the Bazel environment uses
the x86_64 library path for aarch64 builds, making openssl-sys non-hermetic.
Update the aarch64-specific settings in MODULE.bazel to reference Bazel-managed
arm64 OpenSSL headers and libraries, including the required per-platform inputs;
alternatively remove aarch64-unknown-linux-gnu from SUPPORTED_TRIPLES until that
toolchain support exists.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: dcb43f31-9d69-4bad-8f1a-43e8ac6a5138

📥 Commits

Reviewing files that changed from the base of the PR and between 7918da8 and a0b0407.

📒 Files selected for processing (1)
  • MODULE.bazel

Comment thread MODULE.bazel
borao added 2 commits August 4, 2026 22:34
Signed-off-by: Bora Oztekin <boztekin@nvidia.com>
Signed-off-by: Bora Oztekin <boztekin@nvidia.com>
@borao
borao enabled auto-merge August 6, 2026 19:41
@borao
borao added this pull request to the merge queue Aug 6, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Aug 6, 2026
@borao
borao added this pull request to the merge queue Aug 6, 2026
Merged via the queue into main with commit ffebd3b Aug 6, 2026
20 checks passed
@borao
borao deleted the fix/function-autoscaler/restore-multi-arch-build branch August 6, 2026 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants