-
Notifications
You must be signed in to change notification settings - Fork 50
feat(nvcf-compute-plane): gang and MNNVL topology scheduling, KAI/Grove primitives #603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
33f9ecb
feat(nvcf-compute-plane): gang scheduling with KAI MNNVL topology, KA…
estroz c0ea3b9
feat(nvcf-compute-plane): align feature flags and NVCA validationPolicy
estroz 0fd1d03
fix(nvcf-compute-plane): fix example
estroz c7f7af4
feat(nvcf-compute-plane): add grove topology binding
estroz 6d2ded7
chore: refactor topology into two releases
estroz 6f18554
chore(docs): refactor for topology/gang scheduling
estroz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 23 additions & 0 deletions
23
deploy/stacks/nvcf-compute-plane/charts/nvcf-cluster-topology/Chart.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # https://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| apiVersion: v2 | ||
| name: nvcf-cluster-topology | ||
| description: >- | ||
| Cluster-scoped KAI Topology and Grove ClusterTopologyBinding resources for | ||
| NVCF MNNVL topology-aware scheduling | ||
| type: application | ||
| version: 0.1.0 | ||
| appVersion: "0.1.0" |
40 changes: 40 additions & 0 deletions
40
deploy/stacks/nvcf-compute-plane/charts/nvcf-cluster-topology/templates/_helpers.tpl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| {{/* | ||
| SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| https://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */}} | ||
|
|
||
| {{- define "nvcf-cluster-topology.name" -}} | ||
| {{- default .Chart.Name .Values.nameOverride | trunc 63 | trimSuffix "-" -}} | ||
| {{- end -}} | ||
|
|
||
| {{- define "nvcf-cluster-topology.labels" -}} | ||
| helm.sh/chart: {{ .Chart.Name }}-{{ .Chart.Version | replace "+" "_" }} | ||
| app.kubernetes.io/name: {{ include "nvcf-cluster-topology.name" . }} | ||
| app.kubernetes.io/instance: {{ .Release.Name }} | ||
| app.kubernetes.io/version: {{ .Chart.AppVersion | quote }} | ||
| app.kubernetes.io/managed-by: {{ .Release.Service }} | ||
| {{- with .Values.commonLabels }} | ||
| {{ toYaml . }} | ||
| {{- end }} | ||
| {{- end -}} | ||
|
|
||
| {{/* | ||
| Derive a Grove domain name from a KAI nodeLabel: last path element with '.' removed. | ||
| Example: nvidia.com/gpu.clique -> gpuclique; kubernetes.io/hostname -> hostname | ||
| */}} | ||
| {{- define "nvcf-cluster-topology.groveDomain" -}} | ||
| {{- $nodeLabel := . | required "nvcf-cluster-topology: every level must set nodeLabel" -}} | ||
| {{- $nodeLabel | splitList "/" | last | replace "." "" -}} | ||
| {{- end -}} |
62 changes: 62 additions & 0 deletions
62
...s/nvcf-compute-plane/charts/nvcf-cluster-topology/templates/cluster-topology-binding.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| {{/* | ||
| SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| https://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */}} | ||
|
|
||
| {{- if .Values.groveOperator.enabled }} | ||
| {{- $topologies := .Values.topologies | default list }} | ||
| {{- if empty $topologies }} | ||
| {{- fail "nvcf-cluster-topology: topologies must contain at least one entry when groveOperator.enabled is true" }} | ||
| {{- end }} | ||
| {{- $schedulerName := .Values.groveOperator.topologyBindingSchedulerName | default "kai-scheduler" }} | ||
| {{- range $i, $topo := $topologies }} | ||
| {{- $levels := $topo.levels | default list }} | ||
| {{- if empty $levels }} | ||
| {{- fail (printf "nvcf-cluster-topology: topology %q must set at least one level" ($topo.name | default "<unnamed>")) }} | ||
| {{- end }} | ||
| {{- $topoName := $topo.name | required "nvcf-cluster-topology: every topology must set name" }} | ||
| --- | ||
| # SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # https://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| apiVersion: grove.io/v1alpha1 | ||
| kind: ClusterTopologyBinding | ||
| metadata: | ||
| name: {{ printf "%s-binding" $topoName }} | ||
| labels: | ||
| {{- include "nvcf-cluster-topology.labels" $ | nindent 4 }} | ||
| spec: | ||
| levels: | ||
| {{- range $levels }} | ||
| - domain: {{ include "nvcf-cluster-topology.groveDomain" .nodeLabel | quote }} | ||
| key: {{ .nodeLabel | required "nvcf-cluster-topology: every level must set nodeLabel" | quote }} | ||
| {{- end }} | ||
| schedulerTopologyBindings: | ||
| - schedulerName: {{ $schedulerName | quote }} | ||
| topologyReference: {{ $topoName | quote }} | ||
| {{- end }} | ||
| {{- end }} |
56 changes: 56 additions & 0 deletions
56
deploy/stacks/nvcf-compute-plane/charts/nvcf-cluster-topology/templates/topology.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| {{/* | ||
| SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| https://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */}} | ||
|
|
||
| {{- if .Values.kaiScheduler.enabled }} | ||
| {{- $topologies := .Values.topologies | default list }} | ||
| {{- if empty $topologies }} | ||
| {{- fail "nvcf-cluster-topology: topologies must contain at least one entry when kaiScheduler.enabled is true" }} | ||
| {{- end }} | ||
| {{- range $i, $topo := $topologies }} | ||
| {{- $levels := $topo.levels | default list }} | ||
| {{- if empty $levels }} | ||
| {{- fail (printf "nvcf-cluster-topology: topology %q must set at least one level" ($topo.name | default "<unnamed>")) }} | ||
| {{- end }} | ||
| --- | ||
| # SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # https://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| apiVersion: kai.scheduler/v1alpha1 | ||
| kind: Topology | ||
| metadata: | ||
| name: {{ $topo.name | required "nvcf-cluster-topology: every topology must set name" }} | ||
| labels: | ||
| {{- include "nvcf-cluster-topology.labels" $ | nindent 4 }} | ||
| spec: | ||
| levels: | ||
| {{- range $levels }} | ||
| - nodeLabel: {{ .nodeLabel | required "nvcf-cluster-topology: every level must set nodeLabel" | quote }} | ||
| {{- end }} | ||
| {{- end }} | ||
| {{- end }} |
44 changes: 44 additions & 0 deletions
44
deploy/stacks/nvcf-compute-plane/charts/nvcf-cluster-topology/values.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # https://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| # Cluster-scoped Topology resources to install when kaiScheduler.enabled is | ||
| # true. Workloads reference a Topology by name through the | ||
| # `kai.scheduler/topology` annotation. | ||
| # | ||
| # Each entry needs: | ||
| # name: Topology resource name | ||
| # levels: node labels ordered widest domain first, narrowest last | ||
| # | ||
| # When groveOperator.enabled is true, each topologies entry also yields a | ||
| # ClusterTopologyBinding named <name>-binding. Grove level domain is the last | ||
| # path element of nodeLabel with '.' removed; key is nodeLabel. | ||
| topologies: | ||
| - name: nvcf-mnnvl-topology | ||
| levels: | ||
| - nodeLabel: nvidia.com/gpu.clique | ||
| - nodeLabel: kubernetes.io/hostname | ||
|
|
||
| # When true, render kai.scheduler/v1alpha1 Topology CRs from topologies. | ||
| kaiScheduler: | ||
| enabled: false | ||
|
|
||
| # When true, render a grove.io/v1alpha1 ClusterTopologyBinding per topologies | ||
| # entry, derived from that entry's levels. | ||
| # topologyBindingSchedulerName sets schedulerTopologyBindings[].schedulerName. | ||
| groveOperator: | ||
| enabled: false | ||
| topologyBindingSchedulerName: kai-scheduler | ||
|
|
||
| commonLabels: {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.