Skip to content

fix(ci): stop failing PRs that touch only docker-host subtrees #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balajinvda merged 1 commit into from
Jul 29, 2026
Merged

fix(ci): stop failing PRs that touch only docker-host subtrees #553

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions .github/workflows/bazel.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,12 @@ jobs:
bazel:
name: bazel (${{ matrix.subtree.id }})
needs: detect
if: needs.detect.outputs.any == 'true'
# Guard on THIS lane's matrix, not the combined `any`. A change touching
# only docker-host subtrees leaves this matrix empty while `any` is still
# true; GitHub cannot create a job from an empty matrix vector and resolves
# it to `failure`, not `skipped`, which failed the required check on PRs
# that had nothing wrong with them. bazel-docker already guards this way.
if: needs.detect.outputs.matrix != '[]'
runs-on: ubuntu-latest
# Public EC2 Buildbarn cache (grpcs, bearer-token gated). The token is a
# repo secret, so fork PRs (which never receive secrets) fall back to a
Expand Down Expand Up @@ -938,8 +943,14 @@ jobs:
exit 0
fi

if [ "${BAZEL_RESULT}" != "success" ]; then
echo "one or more Bazel matrix rows failed, were cancelled, or were skipped"
# `skipped` is legitimate here and means the build-container matrix was
# empty, i.e. every selected subtree runs in the docker-host lane. The
# job's `if` is tied to that matrix being non-empty, so skipped can
# only mean "nothing for this lane to do" -- it cannot hide a row that
# should have run. The BAZEL_ANY check above already catches the case
# where no subtree was selected at all.
if [ "${BAZEL_RESULT}" != "success" ] && [ "${BAZEL_RESULT}" != "skipped" ]; then
echo "one or more Bazel matrix rows failed or were cancelled"
exit 1
fi

Expand Down
Loading