feat(byoo): retain exporter diagnostic metrics - #532
Merged
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (90)
🚧 Files skipped from review as they are similar to previous changes (87)
📝 WalkthroughWalkthroughThe BYOO OTel Collector version is updated to ChangesBYOO OTel metric allowlists
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/compute-plane-services/byoo-otel-collector/internal/otelconfig/templates/config-k8s-container.yaml.tmpl (1)
106-106: 🎯 Functional Correctness | 🔵 Trivial | 💤 Low valueNarrow the duration-sample regex. Replace
.*with explicit histogram suffixes (_bucket|_count|_sum) so the allowlist stays limited to the current Collector metric family.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/compute-plane-services/byoo-otel-collector/internal/otelconfig/templates/config-k8s-container.yaml.tmpl` at line 106, Replace the wildcard duration suffixes in the metric allowlist regex at src/compute-plane-services/byoo-otel-collector/internal/otelconfig/templates/config-k8s-container.yaml.tmpl:106 with only _bucket, _count, or _sum. Apply the same narrowing to the corresponding regex at line 39 in each sibling file: src/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_function_helm_azure_monitor.yaml, config_function_helm_input1.yaml, config_function_helm_input2.yaml, config_function_helm_input3.yaml, config_function_helm_input4.yaml, config_function_helm_kratos_logs_stg.yaml, config_function_helm_kratos_thanos_prd.yaml, config_function_helm_kratos_thanos_stg.yaml, config_function_helm_otelcollector_stg.yaml, and config_function_helm_telemetry_endpoint_kratos_thanos_stg.yaml.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/compute-plane-services/byoo-otel-collector/generator/source-config.yaml`:
- Around line 444-450: Add focused generator regression coverage for the
allowlist entries shown in source-config.yaml, verifying exact metric names and
wildcard families such as otelcol_http_client_request_duration_seconds.* and
otelcol_rpc_client_call_duration_seconds.* are transformed into the expected
keep-regex templates. Apply the same coverage to the additionally flagged
entries, reusing the existing generator test and validation helpers.
---
Nitpick comments:
In
`@src/compute-plane-services/byoo-otel-collector/internal/otelconfig/templates/config-k8s-container.yaml.tmpl`:
- Line 106: Replace the wildcard duration suffixes in the metric allowlist regex
at
src/compute-plane-services/byoo-otel-collector/internal/otelconfig/templates/config-k8s-container.yaml.tmpl:106
with only _bucket, _count, or _sum. Apply the same narrowing to the
corresponding regex at line 39 in each sibling file:
src/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_function_helm_azure_monitor.yaml,
config_function_helm_input1.yaml, config_function_helm_input2.yaml,
config_function_helm_input3.yaml, config_function_helm_input4.yaml,
config_function_helm_kratos_logs_stg.yaml,
config_function_helm_kratos_thanos_prd.yaml,
config_function_helm_kratos_thanos_stg.yaml,
config_function_helm_otelcollector_stg.yaml, and
config_function_helm_telemetry_endpoint_kratos_thanos_stg.yaml.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 08695463-9815-41b6-ad73-db654225be78
⛔ Files ignored due to path filters (4)
src/compute-plane-services/byoo-otel-collector/generator/gen/generated_src-config-k8s-container.yaml.tmplis excluded by!**/gen/**src/compute-plane-services/byoo-otel-collector/generator/gen/generated_src-config-k8s-helm.yaml.tmplis excluded by!**/gen/**src/compute-plane-services/byoo-otel-collector/generator/gen/generated_src-config-vm-container.yaml.tmplis excluded by!**/gen/**src/compute-plane-services/byoo-otel-collector/generator/gen/generated_src-config-vm-helm.yaml.tmplis excluded by!**/gen/**
📒 Files selected for processing (88)
src/compute-plane-services/byoo-otel-collector/VERSIONsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_container_azure_monitor.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_container_input1.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_container_input2.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_container_input3.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_container_input4.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_container_kratos_logs_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_container_kratos_thanos_prd.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_container_kratos_thanos_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_container_metric_subset.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_container_otelcollector_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_container_telemetry_endpoint_kratos_thanos_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_helm_azure_monitor.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_helm_input1.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_helm_input2.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_helm_input3.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_helm_input4.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_helm_kratos_logs_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_helm_kratos_thanos_prd.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_helm_kratos_thanos_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_helm_otelcollector_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_helm_telemetry_endpoint_kratos_thanos_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_task_container_azure_monitor.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_task_container_input1.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_task_container_input2.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_task_container_input3.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_task_container_input4.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_task_container_kratos_logs_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_task_container_kratos_thanos_prd.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_task_container_kratos_thanos_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_task_container_otelcollector_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_task_container_telemetry_endpoint_kratos_thanos_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_task_helm_azure_monitor.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_task_helm_input1.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_task_helm_input2.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_task_helm_input3.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_task_helm_input4.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_task_helm_kratos_logs_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_task_helm_kratos_thanos_prd.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_task_helm_kratos_thanos_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_task_helm_otelcollector_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_task_helm_telemetry_endpoint_kratos_thanos_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_function_container_azure_monitor.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_function_container_input1.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_function_container_input2.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_function_container_input3.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_function_container_input4.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_function_container_kratos_logs_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_function_container_kratos_thanos_prd.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_function_container_kratos_thanos_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_function_container_otelcollector_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_function_container_telemetry_endpoint_kratos_thanos_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_function_helm_azure_monitor.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_function_helm_input1.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_function_helm_input2.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_function_helm_input3.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_function_helm_input4.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_function_helm_kratos_logs_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_function_helm_kratos_thanos_prd.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_function_helm_kratos_thanos_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_function_helm_otelcollector_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_function_helm_telemetry_endpoint_kratos_thanos_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_task_container_azure_monitor.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_task_container_input1.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_task_container_input2.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_task_container_input3.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_task_container_input4.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_task_container_kratos_logs_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_task_container_kratos_thanos_prd.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_task_container_kratos_thanos_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_task_container_otelcollector_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_task_container_telemetry_endpoint_kratos_thanos_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_task_helm_azure_monitor.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_task_helm_input1.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_task_helm_input2.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_task_helm_input3.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_task_helm_input4.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_task_helm_kratos_logs_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_task_helm_kratos_thanos_prd.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_task_helm_kratos_thanos_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_task_helm_otelcollector_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_task_helm_telemetry_endpoint_kratos_thanos_stg.yamlsrc/compute-plane-services/byoo-otel-collector/generator/doc/README.mdsrc/compute-plane-services/byoo-otel-collector/generator/source-config.yamlsrc/compute-plane-services/byoo-otel-collector/internal/otelconfig/templates/config-k8s-container.yaml.tmplsrc/compute-plane-services/byoo-otel-collector/internal/otelconfig/templates/config-k8s-helm.yaml.tmplsrc/compute-plane-services/byoo-otel-collector/internal/otelconfig/templates/config-vm-container.yaml.tmplsrc/compute-plane-services/byoo-otel-collector/internal/otelconfig/templates/config-vm-helm.yaml.tmpl
kristinapathak
force-pushed
the
kpathak/byoo-exporter-metrics
branch
from
August 3, 2026 05:17
3a346d5 to
ba0b72e
Compare
vrv3814
approved these changes
Aug 3, 2026
Retain HTTP, gRPC, queue, and enqueue diagnostics from the Collector self-scrape. Regenerate BYOO templates and examples. Refs #531 Signed-off-by: Kristina Pathak <kpathak@nvidia.com>
kristinapathak
force-pushed
the
kpathak/byoo-exporter-metrics
branch
from
August 3, 2026 05:53
3d97c30 to
9795e8e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Additional Details
For the Reviewer
generator/source-config.yaml; generated templates and examples follow from its two Collector allowlists.For QA
go test ./...and./scripts/validate-otelconfig.shacross VM, Kubernetes-container, and Kubernetes-Helm modes.Issues
Closes #531
Checklist
Github commit:
feat(byoo): retain exporter diagnostic metrics
Retain Collector HTTP, gRPC, queue, and enqueue diagnostics in the BYOO self-scrape so exporter failures can be classified.
Summary by CodeRabbit