Skip to content

fix(cassandra): register nvct with legacy ESS auth #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbaum1994 merged 1 commit into from
Jul 28, 2026
Merged

fix(cassandra): register nvct with legacy ESS auth #494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions migrations/cassandra/keyspaces/ess_api/05_add_nvct_authorizations.up.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
-- Register nvct-api for legacy ESS authentication during the 0.6.x release.
--
-- The 0.6.x ESS API validates service assertions from ssa_authorizations and
-- validates task-secret reads from notary_authorizations.
UPDATE ess_api.namespaces
SET
ssa_authorizations = ssa_authorizations + {
'nvct-api': {
id: 'nvct-api',
name: 'nvct api service client',
jwks_url: 'http://openbao-server.vault-system.svc.cluster.local:8200/v1/services/ess-api/jwt/jwks',
issuer: 'http://ess-api.ess.svc.cluster.local',
type: 'SSA'
}
},
notary_authorizations = notary_authorizations + {
'nvct-api': {
id: 'nvct-api',
name: 'nvct api notary client',
jwks_url: 'http://notary.nvcf.svc.cluster.local:8080/.well-known/jwks.json',
issuer: 'http://notary.nvcf.svc.cluster.local:8080',
type: 'NOTARY'
}
}
WHERE namespace = 'nvcf';
20 changes: 20 additions & 0 deletions migrations/cassandra/tests/test-execute-sqls.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,26 @@ for keyspace_name in ${schema_inventory}; do
done
done

ess_nvct_authorizations="${keyspaces}/ess_api/05_add_nvct_authorizations.up.sql"
if [ ! -f "${ess_nvct_authorizations}" ]; then
fail "ess_api is missing the nvct-api authorization migration"
else
ssa_registration=$(sed -n '/ssa_authorizations = ssa_authorizations + {/,/^ },$/p' "${ess_nvct_authorizations}")
notary_registration=$(sed -n '/notary_authorizations = notary_authorizations + {/,/^ }$/p' "${ess_nvct_authorizations}")

if ! printf '%s\n' "${ssa_registration}" | grep -F -q "'nvct-api': {" || \
! printf '%s\n' "${ssa_registration}" | grep -F -q "type: 'SSA'"
then
fail "ess_api does not register nvct-api for SSA authentication"
fi

if ! printf '%s\n' "${notary_registration}" | grep -F -q "'nvct-api': {" || \
! printf '%s\n' "${notary_registration}" | grep -F -q "type: 'NOTARY'"
then
fail "ess_api does not register nvct-api for notary authentication"
fi
fi

if grep -R -n -F 'envOrDefault "REPLICA_COUNT"' "${keyspaces}"; then
fail "keyspace migrations contain templates unsupported by stock golang-migrate"
fi
Expand Down