fix(byoo): cap chunked log exporter batches - #478
Conversation
Configure exporterhelper byte batching at 900,000 bytes when log chunking is active, leaving space for request envelope overhead. Preserve dry-run behavior and bump the BYOO collector release to 0.157.1. Signed-off-by: Kristina Pathak <kpathak@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe BYO OpenTelemetry collector adds default byte-based batching for chunked log exporters outside dry-run mode, updates test coverage for Kratos log export configuration, and increments the collector version to 0.157.1. ChangesLog exporter batching
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.12.2)level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain main module or its selected dependencies" Comment |
TL;DR
Additional Details
sending_queue.batchwith a 200 ms flush and 100 KB of envelope headroom below the 1 MB receiver limit.For the Reviewer
internal/otelconfig/render.go.For QA
go test ./...make update-examplesproduced no diff.make validate-otelconfigsending_queue.batchshape with the pinned 0.157.0 collector.No documentation changes are needed because this is an automatic safety default.
Issues
Relates to #273
Checklist
Summary by CodeRabbit
New Features
Bug Fixes