fix(self-managed): consume reconnect-enabled SIS chart

[sbaum1994]

TL;DR

Update the self-managed stack SIS dependency from chart 1.18.3 to 1.18.7 so deployments consume the release that enables NATS reconnect.

Additional Details

SIS can retain a closed NATS connection after authentication expiry or a NATS restart. Subsequent JetStream publishes may not reach the worker plane, leaving function deployments in DEPLOYING.

Chart 1.18.7 enables reconnect in the default SIS environment. This change updates only the downstream stack pin. It does not change release ordering, values overrides, or Kubernetes resource shapes.

For the Reviewer

Review the SIS release entry in deploy/stacks/self-managed/helmfile.d/02-core.yaml.gotmpl.

For QA

• git diff --check
• Confirmed chart tag 1.18.7 contains the reconnect fix.
• No cluster QA was run for this one-line stack pin. Existing stack validation covers version-only changes.

Issues

Relates to #391

Checklist

• I am familiar with the Contributing Guidelines.
• I have signed off my commits for Developer Certificate of Origin (DCO) compliance.
• Existing stack validation covers this version-only change.
• No documentation update is required for the dependency pin.

Dependencies

• helm-nvcf-sis 1.18.7
• No new third-party dependency, license review, or NOTICE update is required.

Summary by CodeRabbit

• Chores
  • Updated the self-managed deployment package to use the newer SIS chart version (1.18.7).
  • Includes fixes and improvements delivered with the updated chart.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: ba7c4214-4942-4daa-9e62-be0a19f6f8e5

📥 Commits

Reviewing files that changed from the base of the PR and between 27354d4 and ababfe0.

📒 Files selected for processing (1)

• deploy/stacks/self-managed/helmfile.d/02-core.yaml.gotmpl

🚧 Files skipped from review as they are similar to previous changes (1)

• deploy/stacks/self-managed/helmfile.d/02-core.yaml.gotmpl

---

📝 Walkthrough

Walkthrough

The self-managed Helmfile updates the sis release chart version from 1.18.3 to 1.18.7.

Changes

SIS chart update

Layer / File(s)	Summary
Update SIS release version deploy/stacks/self-managed/helmfile.d/02-core.yaml.gotmpl	The sis Helm release version is updated from 1.18.3 to 1.18.7.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

• NVIDIA/nvcf#434: Updates the same SIS Helm chart version pin in the same Helmfile.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title follows Conventional Commits and accurately reflects the chart update and reconnect fix in the self-managed stack.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch sbaum1994/fix/sis-chart-1.18.7

---

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@deploy/stacks/self-managed/helmfile.d/02-core.yaml.gotmpl`:
- Line 42: Add validation for the chart version in the Helmfile configuration
around the version declaration, using a repository-native Helmfile render or
version-resolution check to verify the dependency resolves correctly. If such
validation is not applicable, document the justification in the PR instead.
- Line 42: Update the helm-nvcf-sis version in docs/version-catalog/main.yaml to
match the 1.18.7 value in the Helmfile, then regenerate docs/user/manifest.md
from the updated catalog so both documentation artifacts are synchronized.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 5a03f669-ef7b-41ca-9716-c46b62458bef

📥 Commits

Reviewing files that changed from the base of the PR and between b945418 and 5181641.

📒 Files selected for processing (1)

• deploy/stacks/self-managed/helmfile.d/02-core.yaml.gotmpl

[dmikhaylovnv]

LGTM

[sbaum1994]

Not needed newer image was added by Ada