feat(gateway-routes): add opt-in HTTPRoute for the nvcf-ui addon

[vrv3814]

Why

Deployments that install the nvcf-ui addon need to expose the UI through the
shared Gateway. This adds an opt-in
HTTPRoute plus the cross-namespace ReferenceGrant that the route requires.

What changed

• New httproute-nvcf-ui.yaml: HTTPRoute attached to the shared Gateway,
  matching PathPrefix / on the nvcf-ui.<domain> hostname and forwarding to
  the nvcf-ui Service (namespace nvcf-ui, port 8300).
• New referencegrant-nvcf-ui.yaml: ReferenceGrant permitting HTTPRoutes in the
  shared Gateway namespace to reference the nvcf-ui Service across namespaces.
• values.yaml: new routes.nvcfUi block, enabled: false by default so the
  route only renders when a deployment opts in.
• _helpers.tpl: added nvcfUi to the root-hostname uniqueness validation list
  so a duplicate root PathPrefix / hostname is caught at template time.

Both templates are guarded by nvcfGatewayRoutes.enabled and
routes.nvcfUi.enabled, so nothing renders unless the addon is turned on.

Customer Release Notes

Adds an opt-in gateway route that exposes the nvcf-ui addon through the shared
Gateway when enabled.

Plan Summary

When routes.nvcfUi.enabled=true, renders one HTTPRoute and one ReferenceGrant.
No resources render by default.

Usage

Enable in values:

nvcfGatewayRoutes:
  routes:
    nvcfUi:
      enabled: true

Testing

Rendered the chart with helm template for nvcfUi enabled and disabled;
confirmed both resources appear only when enabled and the hostname uniqueness
check passes.

Issues

Closes #313

References

None

Related Pull Requests

None

Dependencies

None

Summary by CodeRabbit

• New Features

  • Added optional HTTP routing for the NVCF UI through the shared Gateway.
  • Configured default hostname and backend service routing on port 8300.
  • Added permission handling for cross-namespace UI service access.

• Bug Fixes

  • Expanded hostname conflict detection to include the NVCF UI route.

Summary by CodeRabbit

• New Features

  • Added optional Gateway routing for the NVCF UI, including hostname matching and backend forwarding.
  • Added cross-namespace access configuration for the NVCF UI route.
  • Added hostname conflict detection for the NVCF UI route.

• Bug Fixes

  • Improved pull request issue validation for content using CRLF line endings.

[coderabbitai]

📝 Walkthrough

Walkthrough

Adds an opt-in NVCF UI HTTPRoute and cross-namespace ReferenceGrant to the shared Gateway, includes the route in hostname uniqueness validation, and adds a CRLF parsing acceptance test.

Changes

NVCF UI Gateway routing

Layer / File(s)	Summary
Route configuration and hostname validation deploy/helm/gateway-routes/chart/values.yaml, deploy/helm/gateway-routes/chart/templates/_helpers.tpl	Adds disabled-by-default nvcfUi route settings and includes its hostnames in uniqueness validation.
NVCF UI Gateway resources deploy/helm/gateway-routes/chart/templates/httproute-nvcf-ui.yaml, deploy/helm/gateway-routes/chart/templates/referencegrant-nvcf-ui.yaml	Conditionally renders the shared-Gateway HTTPRoute and the ReferenceGrant allowing cross-namespace access to the NVCF UI Service.

PR body line-ending handling

Layer / File(s)	Summary
Issue checker line-ending acceptance test ci/test/check-pr-issue.test.sh	Adds a passing case for Issues/Checklist content using CRLF line endings.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant Client
  participant SharedGateway
  participant HTTPRoute
  participant NVCFUIService
  Client->>SharedGateway: Request nvcf-ui hostname
  SharedGateway->>HTTPRoute: Match hostname and PathPrefix /
  HTTPRoute->>NVCFUIService: Forward request to port 8300

Loading

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Out of Scope Changes check	⚠️ Warning	The CRLF parsing test for check-pr-issue.sh is unrelated to exposing nvcf-ui through the shared Gateway.	Move the check-pr-issue.sh test update to a separate PR unless it is required for this gateway-routes change.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title is valid Conventional Commits and accurately summarizes the gateway-routes feature.
Linked Issues check	✅ Passed	The PR implements the opt-in HTTPRoute, ReferenceGrant, defaults, guards, and hostname validation required by #313.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch add-nvcf-ui-routes

---

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@deploy/helm/gateway-routes/chart/templates/httproute-nvcf-ui.yaml`:
- Around line 16-50: Add Helm chart tests for the opt-in nvcfUi route
configuration, verifying it renders disabled by default, produces the expected
HTTPRoute and matching ReferenceGrant fields when enabled, and fails when
hostnames are duplicated. Use the existing chart test conventions and symbols
under nvcfGatewayRoutes.routes.nvcfUi; if testing is not supported in this
location, document the reason in the PR description.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: d3e14059-ca20-472a-bfd6-056249c09066

📥 Commits

Reviewing files that changed from the base of the PR and between 5ef95ed and 569e925.

📒 Files selected for processing (4)

• deploy/helm/gateway-routes/chart/templates/_helpers.tpl
• deploy/helm/gateway-routes/chart/templates/httproute-nvcf-ui.yaml
• deploy/helm/gateway-routes/chart/templates/referencegrant-nvcf-ui.yaml
• deploy/helm/gateway-routes/chart/values.yaml

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@deploy/helm/gateway-routes/chart/templates/referencegrant-nvcf-ui.yaml`:
- Around line 35-38: Update the ReferenceGrant’s spec.to entry in the manifest
template to include the configured backend Service name, using the chart’s
existing Service-name value. Keep the group and kind values unchanged so
cross-namespace access is restricted to that specific Service.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 100faaa2-50be-4fb9-a03a-54ce739ae034

📥 Commits

Reviewing files that changed from the base of the PR and between 7a004a6 and c30afc0.

📒 Files selected for processing (5)

• ci/test/check-pr-issue.test.sh
• deploy/helm/gateway-routes/chart/templates/_helpers.tpl
• deploy/helm/gateway-routes/chart/templates/httproute-nvcf-ui.yaml
• deploy/helm/gateway-routes/chart/templates/referencegrant-nvcf-ui.yaml
• deploy/helm/gateway-routes/chart/values.yaml

🚧 Files skipped from review as they are similar to previous changes (1)

• deploy/helm/gateway-routes/chart/values.yaml

[balajinvda]

🎉 This PR is included in version nvcf-gateway-routes-v1.15.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀