Skip to content

docs(agents): note .gitlab-ci.yml is internal in root AGENTS.md - #260

Merged
balajinvda merged 1 commit into
NVIDIA:mainfrom
mesutoezdil:mesutoezdil/docs/gitlab-ci-internal-note
Jul 20, 2026
Merged

docs(agents): note .gitlab-ci.yml is internal in root AGENTS.md#260
balajinvda merged 1 commit into
NVIDIA:mainfrom
mesutoezdil:mesutoezdil/docs/gitlab-ci-internal-note

Conversation

@mesutoezdil

@mesutoezdil mesutoezdil commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

The GitLab CI for native subprojects section references .gitlab-ci.yml and tools/ci/generated-release-jobs.yml without noting they are internal config not present in this public snapshot, unlike tools/ci/subproject-validations.yaml which already got that note in #213. Added the same disclaimer here.

Refs: NO-REF

Summary by CodeRabbit

  • Documentation
    • Clarified where native subproject CI jobs are defined.
    • Documented that certain CI configuration files are internal and excluded from public snapshots.

The GitLab CI for native subprojects section documents .gitlab-ci.yml
and tools/ci/generated-release-jobs.yml without noting they are
internal config, unlike tools/ci/subproject-validations.yaml which
already got that note in NVIDIA#213. Added the same disclaimer here.

JIRA: NO-REF
NVBug: none
Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
@mesutoezdil
mesutoezdil requested a review from a team as a code owner July 20, 2026 13:02
@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 2025827d-3bce-4391-a606-e632e8d66046

📥 Commits

Reviewing files that changed from the base of the PR and between adfbbd8 and 85fe1c4.

📒 Files selected for processing (1)
  • AGENTS.md

📝 Walkthrough

Walkthrough

Updated AGENTS.md to clarify that native subproject CI jobs are not declared in the umbrella pipeline and that related CI configuration files are internal and excluded from the public snapshot.

Changes

CI guidance clarification

Layer / File(s) Summary
Native subproject CI documentation
AGENTS.md
Clarifies native subproject job locations and identifies internal GitLab CI configuration files excluded from the public snapshot.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the documentation update clarifying that .gitlab-ci.yml is internal in the root AGENTS.md.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@balajinvda balajinvda left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@balajinvda
balajinvda added this pull request to the merge queue Jul 20, 2026
Merged via the queue into NVIDIA:main with commit 5b1ee44 Jul 20, 2026
14 checks passed
@mesutoezdil
mesutoezdil deleted the mesutoezdil/docs/gitlab-ci-internal-note branch July 28, 2026 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants