-
Notifications
You must be signed in to change notification settings - Fork 17
Integrated Branch for FP8 Bindgen #247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
isVoid
wants to merge
20
commits into
NVIDIA:main
Choose a base branch
from
isVoid:fea-fp8-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
96ffc67
eagerly use all vended numba.cuda modules
isVoid c93c98a
skip unknown types in struct conversion operator gen
isVoid b72a05c
factor out prefix removal helper
isVoid a4d078f
move singular regular method to standalone class, support prefix remo…
isVoid 85271f7
add __nv_bfloat16 test to existing support
isVoid 1582880
support removal of enum prefix, and expose enums to __all__
isVoid e4d45d4
Merge branch 'main' into fea-fp8-support
isVoid 8258429
Merge branch 'main' of github.com:NVIDIA/numbast into fea-fp8-support
isVoid 70001df
add bfloat16_raw type to type system
isVoid 3979ad2
use target registry lower_cast registerer in separate registry mode
isVoid b332cbe
Merge branch 'main' of github.com:NVIDIA/numbast into bump_numba-cuda…
isVoid df501fe
pin numba-cuda versions to >=0.21.0
isVoid 5b10afb
document version requirements for bindings v.s. numba-cuda
isVoid 0fe0bf0
check on numba.cuda.types
isVoid fa5f7af
avoid unused parameter
isVoid 0375b48
use numba_typeref_ctor from vended module
isVoid 855507a
Merge branch 'bump_numba-cuda_ver' into fea-fp8-support
isVoid ac0afbf
adding cudaroundmode enum to type system
isVoid 71be418
Merge branch 'main' into fea-fp8-support
isVoid 3ea27f9
pass through clang binary path to tooling
isVoid File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| // clang-format off | ||
| // SPDX-FileCopyrightText: Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
| // clang-format on | ||
|
|
||
| #pragma once | ||
|
|
||
| __device__ void func_with_void_ptr_arg(void *ptr) { (void)ptr; } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the conditional expression logic.
The condition
if not Nonealways evaluates toTrue, which meansclang_binarywill be used even when it'sNone, causing the command to fail. The correct check should verify whetherclang_binaryitself isNone.🔎 Proposed fix
📝 Committable suggestion
🤖 Prompt for AI Agents