Initialize calling convention and abi info in compile_cuda, not CUDAFlag
#782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Automatic reviews are disabled for this repository. |
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test |
gmarkall
requested changes
Feb 9, 2026
Contributor
gmarkall
left a comment
gmarkall
left a comment
There was a problem hiding this comment.
This fixes the issue in compile_subroutine(), but I want to try and hold off merging it without a proper fix, as it turns a loud failure into a silent miscompilation.
isVoid
changed the title
BaseContext.call_internalcompile_cuda, not CUDAFlag
gmarkall
reviewed
Feb 10, 2026
gmarkall
reviewed
Feb 10, 2026
gmarkall
reviewed
Feb 10, 2026
isVoid
commented
Feb 10, 2026
| # is compiled with numba-abi. So cres should have CUDACallConv. | ||
| assert isinstance(cres.fndesc.call_conv, CUDACallConv) | ||
|
|
||
| _, result = context.call_internal_no_propagate( |
Contributor
Author
There was a problem hiding this comment.
Because wrapper function is CABI function, lower level calls are unable to propagate to top level. Hence using call_internal_no_propagate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #717 makes calling convention a configurable object in target context. In that PR, we attempt to initialize calling convention inside
CUDAFlag. However, justCUDAFlagis also a global config object for codegen, which goes in contradiction to our intention that calling convention should be per-function based. In this PR, we moved the initialization of calling conventions tocompile_cuda, which is meant to be the compile entry point of a cuda function.