-
Notifications
You must be signed in to change notification settings - Fork 55
feat: swap out internal device array usage with StridedMemoryView
#703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
592f5fa
refactor: use `StridedMemoryView` internally
cpcloud c6fd6d7
chore: add patch workaround to allow SMV
cpcloud ad89b66
Fix arg hints in CUDA simulator
gmarkall c7743b5
fix : hack around missing datetime64 in dlpack
cpcloud 455c4f2
chore: issubclass first argument must be a type object
cpcloud c60a443
chore(deps): remove invalid constraints on cuda-core
cpcloud 728b29b
chore: fix shell script comment typo
cpcloud 64b6dd3
test: add test for cuda array interface branch
cpcloud 64504a9
fix: use correct property for numba dtypes for number of bits in a type
cpcloud File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: BSD-2-Clause | ||
| diff --git i/python/cudf/cudf/core/buffer/buffer.py w/python/cudf/cudf/core/buffer/buffer.py | ||
| index 71ab509348..e7e6ea9e5f 100644 | ||
| --- i/python/cudf/cudf/core/buffer/buffer.py | ||
| +++ w/python/cudf/cudf/core/buffer/buffer.py | ||
| @@ -414,7 +414,7 @@ class Buffer(Serializable): | ||
| "shape": (self.size,), | ||
| "strides": None, | ||
| "typestr": "|u1", | ||
| - "version": 0, | ||
| + "version": 3, | ||
| } | ||
|
|
||
| def serialize(self) -> tuple[dict, list]: | ||
| diff --git i/python/cudf/cudf/core/buffer/spillable_buffer.py w/python/cudf/cudf/core/buffer/spillable_buffer.py | ||
| index 52dcd00e2b..a5bc9a461d 100644 | ||
| --- i/python/cudf/cudf/core/buffer/spillable_buffer.py | ||
| +++ w/python/cudf/cudf/core/buffer/spillable_buffer.py | ||
| @@ -337,7 +337,7 @@ class SpillableBufferOwner(BufferOwner): | ||
| "shape": (self.size,), | ||
| "strides": None, | ||
| "typestr": "|u1", | ||
| - "version": 0, | ||
| + "version": 3, | ||
| } | ||
|
|
||
| def memoryview( | ||
| @@ -460,5 +460,5 @@ class SpillableBuffer(ExposureTrackedBuffer): | ||
| "shape": (self.size,), | ||
| "strides": None, | ||
| "typestr": "|u1", | ||
| - "version": 0, | ||
| + "version": 3, | ||
| } | ||
| diff --git i/python/cudf/cudf/core/column/column.py w/python/cudf/cudf/core/column/column.py | ||
| index 1562e4810c..a74a9fe23b 100644 | ||
| --- i/python/cudf/cudf/core/column/column.py | ||
| +++ w/python/cudf/cudf/core/column/column.py | ||
| @@ -1971,7 +1971,7 @@ class ColumnBase(Serializable, BinaryOperand, Reducible): | ||
| "strides": (self.dtype.itemsize,), | ||
| "typestr": self.dtype.str, | ||
| "data": (self.data_ptr, False), | ||
| - "version": 1, | ||
| + "version": 3, | ||
| } | ||
| if self.nullable and self.has_nulls(): | ||
| # Create a simple Python object that exposes the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.