-
Notifications
You must be signed in to change notification settings - Fork 73
fix: Fix race condition in CUDA Simulator #690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
8356c6f
fix: make swapped_cuda_module thread-safe in CUDA simulator
ccam80 41104c5
fix: reduce lock overhead in thread-safe swapped_cuda_module
ccam80 2dd15c9
chore: typo
ccam80 67acbfb
fix: remove remaining race vulnerability while accessing locks dictio…
ccam80 71b2e0b
chore: merge typo-edit commit
ccam80 7d7938e
fix: leave per-module lock intact for whole session
ccam80 1d3a392
Merge branch 'main' into fix-simulator-race
gmarkall 8fb2b52
Fix formatting issue
gmarkall File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: memory leak:
_globals_locks[gid]never cleaned up