-
Notifications
You must be signed in to change notification settings - Fork 55
dev: add tool for comparing benchmarks on two commits #631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
Greptile OverviewGreptile SummaryThis PR adds a benchmark comparison tool that allows developers to compare performance between two git commits without modifying the current working directory.
The tool takes two required arguments (baseline and proposed git refs) and an optional environment flag (defaults to Confidence Score: 4/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant User
participant Script as bench-against.py
participant Git
participant Pixi
participant Pytest
User->>Script: pixi run bench-against <baseline> <proposed>
Script->>Git: rev-parse --show-toplevel
Git-->>Script: git root directory
Script->>Git: worktree add --detach <temp-path> HEAD
Script->>Script: chdir(worktree_path)
Note over Script: Baseline benchmarks
Script->>Git: checkout <baseline>
Script->>Pixi: reinstall -e <env> numba-cuda
Script->>Pixi: run -e <env> bench
Pixi->>Pytest: benchmark tests (autosave results)
Note over Script: Proposed benchmarks
Script->>Git: checkout <proposed>
Script->>Pixi: reinstall -e <env> numba-cuda
Script->>Pixi: run -e <env> benchcmp
Pixi->>Pytest: benchmark tests (compare with saved)
Pytest-->>User: Comparison results
Script->>Git: worktree remove --force <temp-path>
Script->>Script: chdir(original_dir)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 files reviewed, no comments
|
I am not sure why pixi thinks the lockfile isn't up-to-date. |
7866553 to
7ce9e50
Compare
|
/ok to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 files reviewed, 1 comment
8108cea to
5f0c7f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 files reviewed, 1 comment
61ec608 to
e88031c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 files reviewed, no comments
e88031c to
10ff7c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 files reviewed, no comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 files reviewed, no comments
gmarkall
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works for me - many thanks!
|
/ok to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 files reviewed, no comments
|
/ok to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 files reviewed, no comments
Add a tool to compare benchmarks on two commits. Run with
pixi run bench-against