Merged
Conversation
Contributor
Greptile OverviewGreptile SummaryFixed
Confidence Score: 5/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant User
participant Kernel as CUDA Kernel
participant CudaPythonFunction
participant Binding as cuda.bindings.driver
participant Driver as CUDA Driver
User->>Kernel: kernel.overloads[sig]
Kernel->>CudaPythonFunction: get_cufunc()
User->>CudaPythonFunction: cache_config(prefer_shared=True)
CudaPythonFunction->>Binding: CUfunc_cache.CU_FUNC_CACHE_PREFER_SHARED
Binding-->>CudaPythonFunction: flag value (0x01)
CudaPythonFunction->>Driver: cuFuncSetCacheConfig(handle, flag)
Driver-->>CudaPythonFunction: success
CudaPythonFunction-->>User: configuration applied
User->>Kernel: kernel[grid, block](args)
Kernel->>Driver: launch with cache config
Driver-->>User: execution complete
|
012c318 to
c221592
Compare
Contributor
|
/ok to test a23a794 |
Contributor
|
/ok to test |
@gmarkall, there was an error processing your request: See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/ |
Contributor
|
/ok to test 3c14514 |
gmarkall
approved these changes
Dec 4, 2025
Contributor
gmarkall
left a comment
There was a problem hiding this comment.
Many thanks! I've checked with NSight Compute that setting the attributes takes effect.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will be followed by a sequence of work on improving the l1 cache/shared memory configuration implementation as stated here.
This PR fixes the following bug:
with a test that would ensure that this won't regress.