-
Notifications
You must be signed in to change notification settings - Fork 54
Add more thirdparty tests #586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
7748ef6
Rename test-thirdparty to test-thirdparty-cudf
gmarkall 307e23a
Add nvmath-python tests
gmarkall 9924815
Attempt to fix nvmath test script
gmarkall ce12ec6
There is no conda prefix when there's no conda
gmarkall 78b8afe
Try installing nvidia-cutlass
gmarkall e23de8d
Correct typo in quotes
gmarkall a6899c5
Fail fast on nvmath tests and use native traceback while debuging
gmarkall f28dfe2
Generate Numba signature objects when Numba is in use
gmarkall 4b513c3
Consider core Numba number domain and struct model in array type check
gmarkall cfc81d1
Install dx tests requirements too
gmarkall dc1ae2b
Add Dim3 and GridGroup to types module
gmarkall 6ab470b
Try only installing nvidia-mthdx directly
gmarkall f9e0af7
Add thirdparty tests of Awkward Array
gmarkall f7f7164
Use correct wheel for CuPy
gmarkall baf15cd
Correct typo in awkward Github URL
gmarkall 7897334
Disable benchmarks for awkward tests
gmarkall e85e8d7
Don't run awkward tests with -v because it makes the log huge
gmarkall 06e3eac
Merge remote-tracking branch 'NVIDIA/main' into thirdparty-tests
gmarkall fa92cb2
Only run nvmath tests on push to main
gmarkall 9e5c87e
Attempt to make pr job succeed when nvmath-python tests skipped
gmarkall ed99309
Add in a dedicated workflow for merged commits
cryos ae4f2d1
Merge remote-tracking branch 'NVIDIA/main' into thirdparty-tests
gmarkall File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,148 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2024 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: BSD-2-Clause | ||
|
|
||
| name: ci | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - "main" | ||
|
|
||
| jobs: | ||
| pre-commit: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v5 | ||
| - uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 | ||
| - uses: pre-commit/action@2c7b3805fd2a0fd8c1884dcaebf91fc102a13ecd | ||
| with: | ||
| extra_args: --all-files --show-diff-on-failure | ||
| compute-matrix: | ||
| runs-on: ubuntu-latest | ||
| outputs: | ||
| BUILD_MATRIX: ${{ steps.compute-matrix.outputs.BUILD_MATRIX }} | ||
| SIMULATOR_MATRIX: ${{ steps.compute-matrix.outputs.SIMULATOR_MATRIX }} | ||
| TEST_MATRIX: ${{ steps.compute-matrix.outputs.TEST_MATRIX }} | ||
| steps: | ||
| - uses: actions/checkout@v5 | ||
| - name: Compute Matrices | ||
| id: compute-matrix | ||
| run: | | ||
| BUILD_MATRIX="$(yq '.build-matrix' ci/matrix.yml)" | ||
| SIMULATOR_MATRIX="$(yq '.simulator-matrix' ci/matrix.yml)" | ||
| TEST_MATRIX="$(yq '.test-matrix' ci/matrix.yml)" | ||
| { | ||
| echo 'BUILD_MATRIX<<EOF' | ||
| echo "${BUILD_MATRIX}" | ||
| echo 'EOF' | ||
| echo 'SIMULATOR_MATRIX<<EOF' | ||
| echo "${SIMULATOR_MATRIX}" | ||
| echo 'EOF' | ||
| echo 'TEST_MATRIX<<EOF' | ||
| echo "${TEST_MATRIX}" | ||
| echo 'EOF' | ||
| } >> "${GITHUB_OUTPUT}" | ||
| build-conda: | ||
| needs: | ||
| - compute-matrix | ||
| uses: ./.github/workflows/conda-python-build.yaml | ||
| with: | ||
| build_type: pull-request | ||
| script: "ci/build_conda.sh" | ||
| matrix: ${{ needs.compute-matrix.outputs.BUILD_MATRIX }} | ||
| test-conda: | ||
| needs: | ||
| - compute-matrix | ||
| uses: ./.github/workflows/conda-python-tests.yaml | ||
| with: | ||
| build_type: pull-request | ||
| script: "ci/test_conda.sh" | ||
| run_codecov: false | ||
| matrix: ${{ needs.compute-matrix.outputs.TEST_MATRIX }} | ||
| test-simulator: | ||
| needs: | ||
| - compute-matrix | ||
| uses: ./.github/workflows/simulator-test.yaml | ||
| with: | ||
| build_type: pull-request | ||
| script: "ci/test_simulator.sh" | ||
| matrix: ${{ needs.compute-matrix.outputs.SIMULATOR_MATRIX }} | ||
| build-wheels: | ||
| needs: | ||
| - compute-matrix | ||
| uses: ./.github/workflows/wheels-build.yaml | ||
| with: | ||
| build_type: pull-request | ||
| script: "ci/build_wheel.sh" | ||
| matrix: ${{ needs.compute-matrix.outputs.BUILD_MATRIX }} | ||
| build-wheels-windows: | ||
| uses: ./.github/workflows/wheel-windows-build.yaml | ||
| test-wheels-windows: | ||
| needs: | ||
| - build-wheels-windows | ||
| uses: ./.github/workflows/wheel-windows-tests.yaml | ||
| test-wheels: | ||
| needs: | ||
| - build-wheels | ||
| - compute-matrix | ||
| uses: ./.github/workflows/wheels-test.yaml | ||
| with: | ||
| build_type: pull-request | ||
| script: "ci/test_wheel.sh false" | ||
| matrix: ${{ needs.compute-matrix.outputs.TEST_MATRIX }} | ||
| test-wheels-deps-wheels: | ||
| needs: | ||
| - build-wheels | ||
| - compute-matrix | ||
| uses: ./.github/workflows/wheels-test.yaml | ||
| with: | ||
| build_type: pull-request | ||
| script: "ci/test_wheel_deps_wheels.sh" | ||
| matrix: ${{ needs.compute-matrix.outputs.TEST_MATRIX }} | ||
| matrix_filter: map(select(.ARCH == "amd64" and (.CUDA_VER | split(".") | .[0] | tonumber >= 12))) | group_by(.CUDA_VER|split(".")|map(tonumber)|.[0]) | map(max_by([(.PY_VER|split(".")|map(tonumber)), (.CUDA_VER|split(".")|map(tonumber))])) | ||
| test-thirdparty-cudf: | ||
| needs: | ||
| - build-wheels | ||
| - compute-matrix | ||
| uses: ./.github/workflows/wheels-test.yaml | ||
| with: | ||
| build_type: pull-request | ||
| script: "ci/test_thirdparty_cudf.sh" | ||
| matrix: ${{ needs.compute-matrix.outputs.TEST_MATRIX }} | ||
| # TODO: Enable for CUDA 13 when a supporting version of cuDF is available | ||
| matrix_filter: map(select(.ARCH == "amd64" and (.CUDA_VER | split(".") | .[0] | tonumber == 12))) | group_by(.CUDA_VER|split(".")|map(tonumber)|.[0]) | map(max_by([(.PY_VER|split(".")|map(tonumber)), (.CUDA_VER|split(".")|map(tonumber))])) | ||
| test-thirdparty-nvmath: | ||
| needs: | ||
| - build-wheels | ||
| - compute-matrix | ||
| uses: ./.github/workflows/wheels-test.yaml | ||
| with: | ||
| build_type: pull-request | ||
| script: "ci/test_thirdparty_nvmath.sh" | ||
| matrix: ${{ needs.compute-matrix.outputs.TEST_MATRIX }} | ||
| # TODO: Enable for CUDA 13 when a supporting version of nvmath-python is available | ||
| matrix_filter: map(select(.ARCH == "amd64" and (.CUDA_VER | split(".") | .[0] | tonumber == 12))) | group_by(.CUDA_VER|split(".")|map(tonumber)|.[0]) | map(max_by([(.PY_VER|split(".")|map(tonumber)), (.CUDA_VER|split(".")|map(tonumber))])) | ||
| test-thirdparty-awkward: | ||
| needs: | ||
| - build-wheels | ||
| - compute-matrix | ||
| uses: ./.github/workflows/wheels-test.yaml | ||
| with: | ||
| build_type: pull-request | ||
| script: "ci/test_thirdparty_awkward.sh" | ||
| matrix: ${{ needs.compute-matrix.outputs.TEST_MATRIX }} | ||
| # TODO: Enable for CUDA 13 in future | ||
| matrix_filter: map(select(.ARCH == "amd64" and (.CUDA_VER | split(".") | .[0] | tonumber == 12))) | group_by(.CUDA_VER|split(".")|map(tonumber)|.[0]) | map(max_by([(.PY_VER|split(".")|map(tonumber)), (.CUDA_VER|split(".")|map(tonumber))])) | ||
|
|
||
| build-docs: | ||
| uses: ./.github/workflows/docs-build.yaml | ||
| coverage-report: | ||
| needs: | ||
| - build-wheels | ||
| - compute-matrix | ||
| uses: ./.github/workflows/wheels-test.yaml | ||
| with: | ||
| build_type: pull-request | ||
| script: "ci/coverage_report.sh" | ||
| matrix: ${{ needs.compute-matrix.outputs.TEST_MATRIX }} | ||
| matrix_filter: 'map(select(.ARCH == "amd64" and .CUDA_VER == "12.9.1" and .PY_VER == "3.12")) | .[0:1]' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| #!/bin/bash | ||
| # SPDX-FileCopyrightText: Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: BSD-2-Clause | ||
|
|
||
| set -euo pipefail | ||
|
|
||
| CUDA_VER_MAJOR_MINOR=${CUDA_VER%.*} | ||
| AWKWARD_VERSION="2.8.10" | ||
|
|
||
| rapids-logger "Install awkward and related libraries" | ||
|
|
||
| pip install awkward==${AWKWARD_VERSION} cupy-cuda12x pyarrow pandas nox | ||
|
|
||
| rapids-logger "Install wheel with test dependencies" | ||
| package=$(realpath wheel/numba_cuda*.whl) | ||
| echo "Package path: ${package}" | ||
| python -m pip install \ | ||
| "${package}" \ | ||
| "cuda-python==${CUDA_VER_MAJOR_MINOR%.*}.*" \ | ||
| "cuda-core==0.3.*" \ | ||
| "nvidia-nvjitlink-cu12" \ | ||
| --group test | ||
|
|
||
|
|
||
| rapids-logger "Clone awkward repository" | ||
| git clone --recursive https://github.com/scikit-hep/awkward.git | ||
| pushd awkward | ||
| git checkout v${AWKWARD_VERSION} | ||
|
|
||
| rapids-logger "Generate awkward tests" | ||
| nox -s prepare -- --tests | ||
|
|
||
| rapids-logger "Check GPU usage" | ||
| nvidia-smi | ||
|
|
||
| rapids-logger "Show Numba system info" | ||
| python -m numba --sysinfo | ||
|
|
||
| rapids-logger "Run Awkward CUDA tests" | ||
| python -m pytest -n auto --benchmark-disable tests-cuda tests-cuda-kernels tests-cuda-kernels-explicit | ||
|
|
||
| popd |
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| #!/bin/bash | ||
| # SPDX-FileCopyrightText: Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: BSD-2-Clause | ||
|
|
||
| set -euo pipefail | ||
|
|
||
| CUDA_VER_MAJOR_MINOR=${CUDA_VER%.*} | ||
|
|
||
| NVMATH_PYTHON_VERSION="0.6.0" | ||
| # The commit on Github corresponding to 0.6.0 | ||
| NVMATH_PYTHON_SHA="6bddfa71c39c07804127adeb23f5b0d2168ae38c" | ||
|
|
||
| rapids-logger "Install nvmath-python" | ||
|
|
||
| pip install nvmath-python[cu12,dx]==${NVMATH_PYTHON_VERSION} | ||
|
|
||
| rapids-logger "Remove Extraneous numba-cuda" | ||
| pip uninstall -y numba-cuda | ||
|
|
||
| rapids-logger "Install wheel with test dependencies" | ||
| package=$(realpath wheel/numba_cuda*.whl) | ||
| echo "Package path: ${package}" | ||
| python -m pip install \ | ||
| "${package}" \ | ||
| "cuda-python==${CUDA_VER_MAJOR_MINOR%.*}.*" \ | ||
| "cuda-core==0.3.*" \ | ||
| "nvidia-nvjitlink-cu12" \ | ||
| --group test | ||
|
|
||
|
|
||
| rapids-logger "Shallow clone nvmath-python repository" | ||
| git clone https://github.com/NVIDIA/nvmath-python.git | ||
| pushd nvmath-python | ||
| git checkout ${NVMATH_PYTHON_SHA} | ||
|
|
||
| rapids-logger "Install nvmath-python test dependencies" | ||
| pip install -r requirements/pip/tests.txt | ||
| pip install nvidia-mathdx | ||
| pip install nvidia-cutlass | ||
|
|
||
| rapids-logger "Check GPU usage" | ||
| nvidia-smi | ||
|
|
||
| rapids-logger "Show Numba system info" | ||
| python -m numba --sysinfo | ||
|
|
||
| rapids-logger "Run nvmath-python device tests" | ||
| pushd tests | ||
| # Required for nvmath-python to locate pip-install MathDx | ||
| export SYS_PREFIX=`python -c "import sys; print(sys.prefix)"` | ||
| export MATHDX_HOME=${SYS_PREFIX}/lib/python3.13/site-packages/nvidia/mathdx | ||
| python -m pytest nvmath_tests/device --tb=native -x | ||
|
|
||
| popd | ||
| popd | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RE: clogging up CI, did you try scaling out with multiple pytest workers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did, but the tests use a lot of memory so it's not easy to find a sweet spot that speeds things up and doesn't OOM.