-
Notifications
You must be signed in to change notification settings - Fork 59
Vendor numpy median, percentile, and quantile reduction tests
#567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
brandon-b-miller
wants to merge
30
commits into
NVIDIA:main
Choose a base branch
from
brandon-b-miller:vendor-test-array-reductions-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
beeadd1
basic test, bits and pieces of nrt needed
brandon-b-miller 634e976
some progress
brandon-b-miller 9e12144
Refactor
brandon-b-miller c4d4abe
more reductions
brandon-b-miller 06226f2
fix ufuncs
brandon-b-miller 2f48967
Merge branch 'main' into vendor-test-array-reductions
brandon-b-miller 6611805
enable nrt
brandon-b-miller 7bc54a0
fixes
brandon-b-miller 8f87a44
pass
brandon-b-miller 9969223
faster?
brandon-b-miller 3ad3e1f
Merge branch 'main' into vendor-test-array-reductions
brandon-b-miller ddb0062
Merge branch 'main' into vendor-test-array-reductions
brandon-b-miller 398489b
Apply suggestions from code review
brandon-b-miller b58d757
export
brandon-b-miller a7e24cc
basic
brandon-b-miller 14026e8
add test that exhibits the failure
brandon-b-miller 10f21fd
implement fix
brandon-b-miller 51cf513
Merge branch 'fix-numpy-array-device-copy' into vendor-test-array-red…
brandon-b-miller 054041f
updates
brandon-b-miller 7f5a647
merge/resolve
brandon-b-miller 0595cb9
move files, add NRTEnablingCUDATestCase
brandon-b-miller 108df98
cleanup
brandon-b-miller dd1de26
more tests, buggy copy exposed again
brandon-b-miller 5aa441a
partial list impl
brandon-b-miller 9e4ddfe
merge/refactor
brandon-b-miller 5ab95bc
more tests
brandon-b-miller ebb65ef
Merge branch 'main' into vendor-test-array-reductions-2
brandon-b-miller 12ef058
renaming
brandon-b-miller 814f800
merge/resolve
brandon-b-miller ebfd572
merge/resolve
brandon-b-miller File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: removed memcpy fast path optimization when source and destination layouts match - this causes performance regression for same-layout copies
the original code had:
consider restoring the fast path for performance