Skip to content

Relax the pinning to cuda-core to allow it floating across minor releases #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leofang merged 3 commits into from
Oct 29, 2025
Merged

Relax the pinning to cuda-core to allow it floating across minor releases #559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1e99932
update pinnings
isVoid Oct 28, 2025
44af4df
fix wheel test env
isVoid Oct 29, 2025
d0dc6c4
update pinnings
isVoid Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ci/test_wheel.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ echo "Package path: ${package}"
DEPENDENCIES=(
"${package}"
"cuda-python==${CUDA_VER_MAJOR_MINOR%.*}.*"
"cuda-core==0.3.*"
"cuda-core>=0.3.0,<1.0.0"
Copy link
Contributor

@kkraus14 kkraus14 Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't get a chance to review this PR, but the reason we pinned to 0.3.* previously is because we historically had API breaking changes in minor releases of cuda-core thus far. I fear if someone goes to pull an older version of numba-cuda with this pinning that they'll eventually get cuda-core 0.X where X had breaking changes relative to 0.3 / 0.4 that breaks numba-cuda.

Copy link
Member

@leofang leofang Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #559 (comment)

"--group"
"test"
)
Expand Down
2 changes: 1 addition & 1 deletion conda/recipes/numba-cuda/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ requirements:
- python
- numba >=0.59.1
- cuda-bindings >=12.9.1
- cuda-core ==0.3.*
- cuda-core >=0.3.0,<1.0.0

about:
home: {{ project_urls["Homepage"] }}
Expand Down
6 changes: 3 additions & 3 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,12 @@ authors = [
license = "BSD-2-clause"
license-files = ["LICENSE", "LICENSE.numba"]
requires-python = ">=3.9"
dependencies = ["numba>=0.60.0", "cuda-bindings>=12.9.1,<14.0.0", "cuda-core>=0.3.2,<0.4.0dev0"]
dependencies = ["numba>=0.60.0", "cuda-bindings>=12.9.1,<14.0.0", "cuda-core>=0.3.2,<1.0.0"]

[project.optional-dependencies]
cu12 = [
"cuda-bindings>=12.9.1,<13.0.0",
"cuda-core==0.3.*",
"cuda-core>=0.3.0,<1.0.0",
"cuda-python==12.9.*", # supports all CTK 12.x
"nvidia-cuda-nvcc-cu12", # for libNVVM
"nvidia-cuda-runtime-cu12",
Expand All @@ -37,7 +37,7 @@ cu12 = [
# TODO: Use cuda-toolkit package dependencies - e.g. cuda-toolkit[curand,nvvm,nvrtc]=13.*
cu13 = [
"cuda-bindings==13.*",
"cuda-core==0.3.2,<0.4.0dev0",
"cuda-core>=0.3.2,<1.0.0",
"cuda-python==13.*",
"nvidia-nvvm==13.*",
"nvidia-cuda-runtime==13.*",
Expand Down