deps: remove now-required dependencies from optional dependencies pyproject.toml table#552
Closed
cpcloud wants to merge 1 commit intoNVIDIA:mainfrom
Closed
deps: remove now-required dependencies from optional dependencies pyproject.toml table#552cpcloud wants to merge 1 commit intoNVIDIA:mainfrom
pyproject.toml table#552cpcloud wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
…project.toml` table
Contributor
Author
|
/ok to test |
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
gmarkall
reviewed
Oct 27, 2025
| license-files = ["LICENSE", "LICENSE.numba"] | ||
| requires-python = ">=3.9" | ||
| dependencies = ["numba>=0.60.0", "cuda-bindings>=12.9.1,<14.0.0", "cuda-core>=0.3.2,<0.4.0dev0"] | ||
| dependencies = ["numba>=0.60.0", "cuda-bindings>=12.9.1,<14.0.0", "cuda-core>=0.3,<0.4.0dev0"] |
Contributor
There was a problem hiding this comment.
I think there was a reason that this can't be 0.3.0 or 0.3.1 - will have to see if I can find it.
Contributor
Author
There was a problem hiding this comment.
Hm, okay. I guess the extra optional dependencies aren't causing any harm, and they may be necessary. It would be good to know, but I'm going to close this PR and revert the corresponding changes in #551
Contributor
Author
|
Closing as not needed for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.