Skip to content

perf: remove duplicated size computation #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gmarkall merged 2 commits into from
Oct 21, 2025
Merged

perf: remove duplicated size computation #537

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
063378d
perf: forward dummy array shape, strides, and size to avoid recomputa…
cpcloud Oct 21, 2025
d83c669
perf: use local variables in device array constructor where applicable
cpcloud Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions numba_cuda/numba/cuda/cudadrv/devicearray.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,26 +90,27 @@ def __init__(self, shape, strides, dtype, stream=0, gpu_data=None):
if isinstance(strides, int):
strides = (strides,)
dtype = np.dtype(dtype)
self.ndim = len(shape)
if len(strides) != self.ndim:
itemsize = dtype.itemsize
self.ndim = ndim = len(shape)
if len(strides) != ndim:
raise ValueError("strides not match ndim")
self._dummy = dummyarray.Array.from_desc(
0, shape, strides, dtype.itemsize
self._dummy = dummy = dummyarray.Array.from_desc(
0, shape, strides, itemsize
)
# confirm that all elements of shape are ints
if not all(isinstance(dim, (int, np.integer)) for dim in shape):
raise TypeError("all elements of shape must be ints")
self.shape = tuple(shape)
self.strides = tuple(strides)
self.shape = shape = dummy.shape
self.strides = strides = dummy.strides
self.dtype = dtype
self.size = int(functools.reduce(operator.mul, self.shape, 1))
Copy link
Contributor Author

@cpcloud cpcloud Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the line that is redundant with dummy.size.

self.size = size = dummy.size
# prepare gpu memory
if self.size > 0:
self.alloc_size = _driver.memory_size_from_info(
self.shape, self.strides, self.dtype.itemsize
if size:
self.alloc_size = alloc_size = _driver.memory_size_from_info(
shape, strides, itemsize
)
if gpu_data is None:
gpu_data = devices.get_context().memalloc(self.alloc_size)
gpu_data = devices.get_context().memalloc(alloc_size)
else:
# Make NULL pointer for empty allocation
null = _driver.binding.CUdeviceptr(0)
Expand Down