Skip to content

[Refactor][NFC] Vendor-in more cpython registries for future CUDA-specific changes #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brandon-b-miller merged 10 commits into from
Sep 25, 2025
Merged

[Refactor][NFC] Vendor-in more cpython registries for future CUDA-specific changes #478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
406db17
fix dangling import to intrinsic from numba.core.extending
atmnp Sep 17, 2025
c3a4799
fix dangling unbox import
atmnp Sep 17, 2025
29d9fc3
other dangling intrinsic import
atmnp Sep 17, 2025
ec4ccb4
vendor in some cpython registries - charseq, iterators, listobj, slic…
atmnp Sep 17, 2025
d779527
python 3.9 support
atmnp Sep 17, 2025
117fbd0
Merge branch 'main' into atmn/vendor-in-cpython-2
atmnp Sep 17, 2025
960a6b6
remove ref to legacy type system
atmnp Sep 17, 2025
ad17085
Merge branch 'main' into atmn/vendor-in-cpython-2
atmnp Sep 23, 2025
3354c12
Merge branch 'main' into atmn/vendor-in-cpython-2
brandon-b-miller Sep 24, 2025
8c1ab95
Merge branch 'main' into atmn/vendor-in-cpython-2
atmnp Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions numba_cuda/numba/cuda/core/inline_closurecall.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
compute_live_variables,
)
from numba.core.imputils import impl_ret_untracked
from numba.core.extending import intrinsic
from numba.cuda.extending import intrinsic
Copy link
Contributor

@brandon-b-miller brandon-b-miller Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to confirm my understanding, this is leftover from previous efforts and should be cleaned up, but isn't directly related to the other changes in this PR correct?

Copy link
Contributor Author

@atmnp atmnp Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, our policy so far has been to fix dangling imports as we see them.

from numba.core.typing import signature

from numba.cuda.core import postproc, rewrites
Expand Down Expand Up @@ -1102,7 +1102,7 @@ def codegen(context, builder, sig, args):
def codegen(context, builder, sig, args):
(value,) = args
intp_t = context.get_value_type(types.intp)
from numba.cpython.listobj import ListIterInstance
from numba.cuda.cpython.listobj import ListIterInstance

iterobj = ListIterInstance(context, builder, sig.args[0], value)
return impl_ret_untracked(context, builder, intp_t, iterobj.size)
Expand Down
5 changes: 1 addition & 4 deletions numba_cuda/numba/cuda/core/pythonapi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,10 +209,7 @@ def __init__(self, context, builder):
self.longlong = ir.IntType(ctypes.sizeof(ctypes.c_ulonglong) * 8)
self.ulonglong = self.longlong
self.double = ir.DoubleType()
if config.USE_LEGACY_TYPE_SYSTEM:
self.py_ssize_t = self.context.get_value_type(types.intp)
else:
self.py_ssize_t = self.context.get_value_type(types.c_intp)
self.py_ssize_t = self.context.get_value_type(types.intp)
self.cstring = ir.PointerType(ir.IntType(8))
self.gil_state = ir.IntType(_helperlib.py_gil_state_size * 8)
self.py_buffer_t = ir.ArrayType(
Expand Down
2 changes: 1 addition & 1 deletion numba_cuda/numba/cuda/core/unsafe/bytes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
operations with bytes and workarounds for limitations enforced in userland.
"""

from numba.core.extending import intrinsic
from numba.cuda.extending import intrinsic
from llvmlite import ir
from numba.core import types
from numba.cuda import cgutils
Expand Down
2 changes: 1 addition & 1 deletion numba_cuda/numba/cuda/core/unsafe/eh.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

from numba.core import types, errors
from numba.cuda import cgutils
from numba.core.extending import intrinsic
from numba.cuda.extending import intrinsic


@intrinsic
Expand Down
2 changes: 1 addition & 1 deletion numba_cuda/numba/cuda/core/unsafe/refcount.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

from numba.core import types
from numba.cuda import cgutils
from numba.core.extending import intrinsic
from numba.cuda.extending import intrinsic

_word_type = ir.IntType(64)
_pointer_type = ir.PointerType(ir.IntType(8))
Expand Down
Loading