-
Notifications
You must be signed in to change notification settings - Fork 56
Support CUDA 13, drop support for CUDA 11 #370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
a250d4b
1e6a534
8ebf865
0e75f18
d1dc13c
c1d42c8
3394a19
28957de
57d5047
61380c3
03943a6
2c66e51
1bd3b22
49fcff1
e9ba0a4
1c00df4
39e400b
e5be30f
1420c67
082b618
9306ceb
9b973ba
55991cf
775a9c1
32a453c
239ab8b
d8843ef
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -146,7 +146,8 @@ jobs: | |
| build_type: pull-request | ||
| script: "ci/test_thirdparty.sh" | ||
| matrix: ${{ needs.compute-matrix.outputs.TEST_MATRIX }} | ||
| matrix_filter: map(select(.ARCH == "amd64" and (.CUDA_VER | split(".") | .[0] | tonumber >= 12))) | group_by(.CUDA_VER|split(".")|map(tonumber)|.[0]) | map(max_by([(.PY_VER|split(".")|map(tonumber)), (.CUDA_VER|split(".")|map(tonumber))])) | ||
| # TODO: Enable for CUDA 13 when a supporting version of cuDF is available | ||
| matrix_filter: map(select(.ARCH == "amd64" and (.CUDA_VER | split(".") | .[0] | tonumber == 12))) | group_by(.CUDA_VER|split(".")|map(tonumber)|.[0]) | map(max_by([(.PY_VER|split(".")|map(tonumber)), (.CUDA_VER|split(".")|map(tonumber))])) | ||
| build-docs: | ||
| needs: | ||
| - build-conda | ||
|
|
@@ -162,4 +163,4 @@ jobs: | |
| build_type: pull-request | ||
| script: "ci/coverage_report.sh" | ||
| matrix: ${{ needs.compute-matrix.outputs.TEST_MATRIX }} | ||
| matrix_filter: 'map(select(.ARCH == "amd64" and .CUDA_VER == "12.8.0" and .PY_VER == "3.13")) | .[0:1]' | ||
| matrix_filter: 'map(select(.ARCH == "amd64" and .CUDA_VER == "12.9.1" and .PY_VER == "3.11")) | .[0:1]' | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why was Python downgraded?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Because the matrix changed so that the newer Pythons were tested with CUDA 13, and I wanted to keep the coverage report on a CUDA 12 version. |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need a TODO to re-enable tests with CUDA 13? What requirements are missing? (e.g. cupy, …?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The thirdparty test is presently cuDF, so having a version of cuDF that officially supports CUDA 13 is probably a good criteria for this - I think there's not a CUDA 13-supporting version yet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct. We are waiting on numba-cuda. 🙃 We'll get this sorted out soon enough.