Fix #299: Error message about bindings not working#300
Merged
kkraus14 merged 1 commit intoNVIDIA:mainfrom Jun 15, 2025
Merged
Conversation
To avoid a `ModuleNotFoundError` being raised when there is no `cuda` namespace package installed, we check for a spec for it first before checking for `cuda.bindings`.
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test |
Contributor
Author
|
A check on my machine when |
Contributor
Author
|
I do wonder if there could be other sources of exceptions that we might not catch, from the info in https://docs.python.org/3/library/importlib.html#importlib.util.find_spec - for example, if |
kkraus14
approved these changes
Jun 15, 2025
gmarkall
added a commit
to gmarkall/numba-cuda
that referenced
this pull request
Jun 24, 2025
- Clarify pynvjitlink option precedence. (NVIDIA#303) - update readme and point to the doc (NVIDIA#301) - Fix NVIDIA#299: Error message about bindings not working (NVIDIA#300)
Merged
gmarkall
added a commit
that referenced
this pull request
Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid a
ModuleNotFoundErrorbeing raised when there is nocudanamespace package installed, we check for a spec for it first before checking forcuda.bindings.