Raise better error when cuda.bindings are not available#294
Merged
kkraus14 merged 3 commits intoNVIDIA:mainfrom Jun 12, 2025
Merged
Raise better error when cuda.bindings are not available#294kkraus14 merged 3 commits intoNVIDIA:mainfrom
cuda.bindings are not available#294kkraus14 merged 3 commits intoNVIDIA:mainfrom
Conversation
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
kkraus14
reviewed
Jun 12, 2025
numba_cuda/numba/cuda/__init__.py
Outdated
| "CUDA bindings not found. Please install through " | ||
| "the cuda-bindings[cuXY] package where XY is the " | ||
| "required CUDA version. Alternatively, install " | ||
| "numba-cuda-cuXY to install the required binding " |
Contributor
There was a problem hiding this comment.
numba-cuda-cuXY doesn't exist. For pip there is numba-cuda[cuXY]. For conda, we should just make it all work out of the box where someone would need to forcibly break their environment to hit this error.
Contributor
Author
There was a problem hiding this comment.
For conda I think it should just work right? It should be a required run dependency now.
Contributor
There was a problem hiding this comment.
We need to update the upstream conda-forge recipe, but in the recipe published here, yes.
kkraus14
reviewed
Jun 12, 2025
Contributor
|
/ok to test |
kkraus14
approved these changes
Jun 12, 2025
gmarkall
added a commit
to gmarkall/numba-cuda
that referenced
this pull request
Jun 14, 2025
- NFC: Don't rely on `Dispatcher._compiler` API (NVIDIA#289) - [DOCS] Improve the introduction and installation section of the documentation (NVIDIA#293) - Fix `DeviceNDArray.device_ctypes_pointer` to always be ctypes (NVIDIA#295) - Raise better error when `cuda.bindings` are not available (NVIDIA#294)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raises a better error with instructions of what to do if the base install is used and no user provided cuda bindings are present in the environment.