Skip to content

Add LTO Support with BF16#253

Closed
isVoid wants to merge 19 commits intoNVIDIA:mainfrom
isVoid:fea-bf16-lto-support
Closed

Add LTO Support with BF16#253
isVoid wants to merge 19 commits intoNVIDIA:mainfrom
isVoid:fea-bf16-lto-support

Conversation

@isVoid
Copy link
Contributor

@isVoid isVoid commented May 14, 2025

In #245, we added bfloat16 API bindings. And it turns out that we missed testing the usage of the bindings with lto=True. This PR adds that.

@copy-pr-bot
Copy link

copy-pr-bot bot commented May 14, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@isVoid
Copy link
Contributor Author

isVoid commented May 14, 2025

@gmarkall it comes to me that whether we should adopt the similar usage here: #240 and go out to enable lto=True by default when we use Numbast generated bindings? I occurred to me that the overhead of non-LTO FFI is quite high.

@isVoid
Copy link
Contributor Author

isVoid commented May 14, 2025

/ok to test

@gmarkall
Copy link
Contributor

gmarkall commented May 14, 2025

@gmarkall it comes to me that whether we should adopt the similar usage here: #240 and go out to enable lto=True by default when we use Numbast generated bindings? I occurred to me that the overhead of non-LTO FFI is quite high.

I think we should have a separate PR to enable LTO by default in general as long as pynvjitlink is available and it is new enough for the current GPU. There might be some caveats / nuance to this behaviour, but I think the general approach is that we should be doing LTO as much as possible because it's such a performance win with any external code.

@gmarkall gmarkall added the 2 - In Progress Currently a work in progress label May 14, 2025
@isVoid
Copy link
Contributor Author

isVoid commented Jul 31, 2025

Closing: LTO is on by default. This means bfloat16 are tested under LTO mode currently. This PR now adds little value.

@isVoid isVoid closed this Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 - In Progress Currently a work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments