Merged
Conversation
- The kind of LTO-IR should have been based on the file extension map, not the string `"ltoir"`. - The `add-data()` method was unimplemented for the Ctypes linker. I have left it unimplemented in the `MVCLinker` and `CudaPythonLinker` as the functionality is not needed immediately in these linkers, and they will eventually be removed. - Add a test of adding data to the link via the active code library for all kinds of linkable code.
This was relatively easy to add and fills a gap, so it's been done.
gmarkall
commented
May 6, 2025
Contributor
|
A couple of the cuda 11 jobs are failing with This could be related to the fact that the wrong version of the cuda bindings is coming in somehow: |
ZzEeKkAa
reviewed
May 6, 2025
Comment on lines
+195
to
+203
| files = ( | ||
| (test_device_functions_a, cuda.Archive), | ||
| (test_device_functions_cubin, cuda.Cubin), | ||
| (test_device_functions_cu, cuda.CUSource), | ||
| (test_device_functions_fatbin, cuda.Fatbin), | ||
| (test_device_functions_o, cuda.Object), | ||
| (test_device_functions_ptx, cuda.PTXSource), | ||
| (test_device_functions_ltoir, cuda.LTOIR), | ||
| ) |
Contributor
There was a problem hiding this comment.
Side question, do we want to add pytest to numba-cuda?
Contributor
Author
There was a problem hiding this comment.
Yes - I haven't had time to do anything about it though.
Contributor
There was a problem hiding this comment.
I can help with that next week
Co-authored-by: brandon-b-miller <53796099+brandon-b-miller@users.noreply.github.com>
gmarkall
added
3 - Ready for Review
brandon-b-miller
approved these changes
May 7, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"ltoir".add-data()method was unimplemented for the Ctypes and CUDA Python linkers. I have left it unimplemented in theMVCLinkeras the functionality is not needed immediately in this linkers, and it will eventually be removed.