Skip to content

Conversation

@brandon-b-miller
Copy link
Contributor

Closes #233.

This could use some kind of test, perhaps one that patches out the finder functions to return None just for the duration of that test.

@leofang
Copy link
Member

leofang commented Apr 29, 2025

cc @rwgk for vis

@kkraus14
Copy link
Contributor

This could use some kind of test, perhaps one that patches out the finder functions to return None just for the duration of that test.

Going to merge this without the test. This will be replaced by the path_finder work @rwgk is doing anyway in the near-ish future and that will be more rigorously documented and tested.

@kkraus14 kkraus14 merged commit 8c9c9d0 into NVIDIA:main Apr 29, 2025
37 checks passed
@brandon-b-miller
Copy link
Contributor Author

This could use some kind of test, perhaps one that patches out the finder functions to return None just for the duration of that test.

Going to merge this without the test. This will be replaced by the path_finder work @rwgk is doing anyway in the near-ish future and that will be more rigorously documented and tested.

Got it- thanks, @kkraus14 .

@rwgk
Copy link

rwgk commented Apr 30, 2025

This could use some kind of test, perhaps one that patches out the finder functions to return None just for the duration of that test.

I'd use mocking only as a last resort in this context. I've seen too many ways that can go horribly wrong. (One way I think about it: often creates about as many problems as you're hoping to avoid, if you're lucky.)

Systematic testing against real environments is much better, and I think it's feasible (for the path_finder). (Hopefully not famous last words.)

gmarkall added a commit to gmarkall/numba-cuda that referenced this pull request May 2, 2025
- Fix Invalid NVVM IR emitted when lowering shfl_sync APIs (NVIDIA#231)
- Add Bfloat16 Low++ Bindings (NVIDIA#166)
- Fix cuda.jit decorator inline (NVIDIA#181)
- Feature: cuda specific make_attribute_wrapper (NVIDIA#193)
- return a none tuple if no libdevice path is found (NVIDIA#234)
@gmarkall gmarkall mentioned this pull request May 2, 2025
gmarkall added a commit to gmarkall/numba-cuda that referenced this pull request May 3, 2025
- Local variable debug info deduplication (NVIDIA#222)
- Fix package installation for wheels CI  (NVIDIA#238)
- Fix Invalid NVVM IR emitted when lowering shfl_sync APIs (NVIDIA#231)
- Add Bfloat16 Low++ Bindings (NVIDIA#166)
- Fix cuda.jit decorator inline (NVIDIA#181)
- Feature: cuda specific make_attribute_wrapper (NVIDIA#193)
- return a none tuple if no libdevice path is found (NVIDIA#234)
@gmarkall gmarkall mentioned this pull request May 3, 2025
gmarkall added a commit that referenced this pull request May 3, 2025
- Local variable debug info deduplication (#222)
- Fix package installation for wheels CI  (#238)
- Fix Invalid NVVM IR emitted when lowering shfl_sync APIs (#231)
- Add Bfloat16 Low++ Bindings (#166)
- Fix cuda.jit decorator inline (#181)
- Feature: cuda specific make_attribute_wrapper (#193)
- return a none tuple if no libdevice path is found (#234)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] TypeError on numba.cuda.is_available() with no CUDA installed

4 participants