Fix the debug info of GridGroup type #131
Merged
+27
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The customized CUDA front end type 'GridGroup' maps to the back end type 'ir.IntType(64)' which is defined in numba.cuda.models. The numba DIBuilder emit variable types for simple numeric types by looking into back end type which falls through the 'DW_ATE_float' because the 'datamodel.fe_type' is not 'types.Integer'. So emitting this type through the CUDADIBuilder is needed. Since the type represents the handle of a group object, giving it the encoding of 'DW_ATE_unsigned' should be reasonable. A test is also added in this change. This change addresses NVIDIA#107
Contributor
|
/ok to test |
gmarkall
approved these changes
Feb 21, 2025
Contributor
gmarkall
left a comment
gmarkall
left a comment
There was a problem hiding this comment.
Many thanks! Just waiting for CI.
gmarkall
added a commit
to gmarkall/numba-cuda
that referenced
this pull request
Mar 6, 2025
- Fix linking of external code from callees (NVIDIA#137) - Try using a newer branch workflow (NVIDIA#148) - Move publish step out of `wheels-build.yaml` (NVIDIA#147) - Upload wheels to PyPI from GitHub-hosted runner (NVIDIA#142) - Add paddle to interoperability chapter (NVIDIA#144) - Fix the debug info of GridGroup type (NVIDIA#131) - Remove dead `prepare_cuda_kernel()` (NVIDIA#130) - Add a CUDA DI Builder (NVIDIA#104) - dont launch extra kernels when stats counting is disabled (NVIDIA#127) - Fixup debug metadata in kernel fixup (NVIDIA#97) - Implement debuginfo bool name fix (numba/numba#9888) in numba-cuda (NVIDIA#106)
Merged
gmarkall
added a commit
that referenced
this pull request
Mar 6, 2025
- Fix linking of external code from callees (#137) - Try using a newer branch workflow (#148) - Move publish step out of `wheels-build.yaml` (#147) - Upload wheels to PyPI from GitHub-hosted runner (#142) - Add paddle to interoperability chapter (#144) - Fix the debug info of GridGroup type (#131) - Remove dead `prepare_cuda_kernel()` (#130) - Add a CUDA DI Builder (#104) - dont launch extra kernels when stats counting is disabled (#127) - Fixup debug metadata in kernel fixup (#97) - Implement debuginfo bool name fix (numba/numba#9888) in numba-cuda (#106)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The customized CUDA front end type 'GridGroup' maps to the back end type 'ir.IntType(64)' which is defined in numba.cuda.models.
The numba DIBuilder emit variable types for simple numeric types by looking into back end type which falls through the 'DW_ATE_float' because the 'datamodel.fe_type' is not 'types.Integer'.
So emitting this type through the CUDADIBuilder is needed. Since the type represents the handle of a group object, giving it the encoding of 'DW_ATE_unsigned' should be reasonable.
A test is also added in this change.
This change addresses #107