Skip to content

MLIR Translation: Implement Barrier0Op - #39

Closed
gmarkall wants to merge 1 commit into
NVIDIA:mainfrom
gmarkall:barrier0
Closed

MLIR Translation: Implement Barrier0Op#39
gmarkall wants to merge 1 commit into
NVIDIA:mainfrom
gmarkall:barrier0

Conversation

@gmarkall

@gmarkall gmarkall commented May 12, 2026

Copy link
Copy Markdown
Collaborator

EDIT: I think maybe the git history was rewritten after I built llvm-modern, so although there was only one commit to llvm-version.env, I think the version changed out from under my existing build.

Locally I'm getting a lot of failures like:

FAILED tests/numba_cuda_tests/cudapy/test_atomics.py::TestCudaAtomics::test_atomic_add - RuntimeError: llvm70 translation failed: unsupported NVVM op: nvvm.barrier0

I see it was removed last week in llvm/llvm-project#195608, so I'm not sure if this is because I have some misconfiguration in my setup (non-matching versions of libraries / LLVMs) or because my setup is just a little different from that in CI and I'm running into a legitimate issue, but adding an implementation of the NVVM::Barrier0Op seems to resolve it - making this PR for comments / discussion.

@copy-pr-bot

copy-pr-bot Bot commented May 12, 2026

Copy link
Copy Markdown
Contributor

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@gmarkall
gmarkall marked this pull request as draft May 12, 2026 15:41
@copy-pr-bot

copy-pr-bot Bot commented May 12, 2026

Copy link
Copy Markdown
Contributor

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@gmarkall

Copy link
Copy Markdown
Collaborator Author

/ok to test

@VijayKandiah

Copy link
Copy Markdown
Collaborator

Yes, barrier0 op was recently removed and we bumped the llvm version we pull in to be newer than this change to account for Jie's upstream changes. We shouldn't need to add support for it. This is most likely a local environment misconfiguration. Perhaps you have bindings from an older LLVM installed locally?

@gmarkall gmarkall closed this May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants