MLIR Translation: Implement Barrier0Op - #39
Closed
gmarkall wants to merge 1 commit into
Closed
Conversation
Contributor
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
gmarkall
marked this pull request as draft
May 12, 2026 15:41
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Collaborator
Author
|
/ok to test |
Collaborator
|
Yes, barrier0 op was recently removed and we bumped the llvm version we pull in to be newer than this change to account for Jie's upstream changes. We shouldn't need to add support for it. This is most likely a local environment misconfiguration. Perhaps you have bindings from an older LLVM installed locally? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EDIT: I think maybe the git history was rewritten after I built llvm-modern, so although there was only one commit to llvm-version.env, I think the version changed out from under my existing build.
Locally I'm getting a lot of failures like:
I see it was removed last week in llvm/llvm-project#195608, so I'm not sure if this is because I have some misconfiguration in my setup (non-matching versions of libraries / LLVMs) or because my setup is just a little different from that in CI and I'm running into a legitimate issue, but adding an implementation of the
NVVM::Barrier0Opseems to resolve it - making this PR for comments / discussion.