Drop implicit nvjitlink dependency derived from cudatoolkit - #102
Merged
brandon-b-miller merged 2 commits intoJun 9, 2026
Merged
Conversation
Contributor
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Collaborator
Author
|
/ok to test |
This comment has been minimized.
This comment has been minimized.
leofang
requested changes
Jun 3, 2026
Collaborator
Author
|
ok to test |
leofang
approved these changes
Jun 6, 2026
Member
|
/ok to test d59d000 |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops
nvjitlinkfrom the list of extras installed via thecudatoolkitpypi metapackages. With the current setup, a downstream library that pins thecudatoolkitpackage implicitly pinsnvjitlinkas well, which is a problem if they need 12.9 for instance to ensure MVC.The explicit nvjitlink dependency listed should be sufficient.