Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[no-relnotes] Use reusable workflows for CI #1154

Merged
merged 2 commits into from
Feb 14, 2025
Merged

Conversation

elezar
Copy link
Member

@elezar elezar commented Feb 12, 2025

This PR propses a more agressive split of the CI steps to reusable workflows. We now have the following high-level workflows:

  • A set of basic checks that are run on PR and can be invoked from a workflow
  • A full ci pipeline that is run on push to main and release-* branches (as well as PR copy bot branches)
  • A standalone definition for CodeQL

@elezar elezar force-pushed the update-ci branch 27 times, most recently from bb73cfb to ea8b77c Compare February 13, 2025 10:04
@ArangoGutierrez ArangoGutierrez self-requested a review February 13, 2025 10:40
Comment on lines +77 to +78
if: false
uses: slackapi/[email protected]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArangoGutierrez the upgrade to v2.0.0 has broken this step. I believe the API has changed.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me check and take action for our repos

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed


jobs:
analyze:
name: Analyze Go code with CodeQL
if: always()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be removed

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup

@elezar
Copy link
Member Author

elezar commented Feb 14, 2025

I'm still not 100% about the naming of the steps, but I suppose we can iterate on that at a later point.

@ArangoGutierrez
Copy link
Collaborator

I'm still not 100% about the naming of the steps, but I suppose we can iterate on that at a later point.

same here, not 100% on "basic" but I can't think of a better name

})
It("it should run GPU jobs", func(ctx context.Context) {
By("Creating a GPU job")

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArangoGutierrez just a note. There is an issue with the tests uninstalling the plugin between stanzas. This "fixes" them, but we should follow up at some point.

@elezar elezar merged commit 831c31e into NVIDIA:main Feb 14, 2025
16 checks passed
@elezar elezar deleted the update-ci branch February 14, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants