-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[no-relnotes] Use reusable workflows for CI #1154
Conversation
bb73cfb
to
ea8b77c
Compare
if: false | ||
uses: slackapi/[email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ArangoGutierrez the upgrade to v2.0.0 has broken this step. I believe the API has changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me check and take action for our repos
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
.github/workflows/code_scanning.yaml
Outdated
|
||
jobs: | ||
analyze: | ||
name: Analyze Go code with CodeQL | ||
if: always() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup
Signed-off-by: Evan Lezar <[email protected]>
I'm still not 100% about the naming of the steps, but I suppose we can iterate on that at a later point. |
Signed-off-by: Evan Lezar <[email protected]>
same here, not 100% on "basic" but I can't think of a better name |
}) | ||
It("it should run GPU jobs", func(ctx context.Context) { | ||
By("Creating a GPU job") | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ArangoGutierrez just a note. There is an issue with the tests uninstalling the plugin between stanzas. This "fixes" them, but we should follow up at some point.
This PR propses a more agressive split of the CI steps to reusable workflows. We now have the following high-level workflows:
main
andrelease-*
branches (as well as PR copy bot branches)