Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add garak/data to pip package #969

Merged

Conversation

jmartin-tech
Copy link
Collaborator

@jmartin-tech jmartin-tech commented Oct 31, 2024

Ensure pip install package include all garak/data files.

Verification

  • Install via pip repository reference in a clean env (example base on ubuntu:latest docker container)
apt-get update; apt-get install python3 python3-venv git
python3 -m venv garak
source garak/bin/activate
python -m pip install -U git+https://github.com/jmartin-tech/garak.git@fix/include-data-in-packaging
  • ls -lah garak/lib/python3.12/site-packages/garak/data
  • Verify files such as misp_descriptions.tsv are reporting as on disk

Signed-off-by: Jeffrey Martin <[email protected]>
Copy link
Collaborator

@leondz leondz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks

@jmartin-tech jmartin-tech merged commit 97d6bf8 into NVIDIA:main Oct 31, 2024
8 checks passed
@jmartin-tech jmartin-tech deleted the fix/include-data-in-packaging branch October 31, 2024 14:40
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants