plugin classes should not access DEFAULT_PARAMS
#906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`DEFAULT_PARAMS` are projected onto instances by `Configurable` and should not be directly access from the `dict` CONSTANT in class methods. If the user provided configurtion that overrides the default the user value is found on the instance. Signed-off-by: Jeffrey Martin <[email protected]>
leondz
approved these changes
Sep 9, 2024
There was a problem hiding this comment.
good catch, thanks for tagging me to review this.
hoping that addressing #883 will reduce the chances of things coming in.
i would like one day to get test warnings/failures for things like:
- commits that introduce print() stmts
- mentions of DEFAULT_PARAMS in functions in plugins
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEFAULT_PARAMSare projected onto instances byConfigurableand should not be directly access from thedictCONSTANT in class methods. If the user provided configurtion that overrides the default the user value is found on the instance.