Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filter detector template in tests #874

Merged
merged 1 commit into from
Sep 3, 2024
Merged

filter detector template in tests #874

merged 1 commit into from
Sep 3, 2024

Conversation

jmartin-tech
Copy link
Collaborator

Address testing of detector template class.

This might not be the long term solution.

leondz
leondz approved these changes Sep 3, 2024
View reviewed changes
Copy link
Collaborator

@leondz leondz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is better than just pushing the defaults for detectors.packagehallucination.PackageHallucinationDetector into compliance before it's made into a mixin then this works for me :)

@jmartin-tech jmartin-tech merged commit d92863f into NVIDIA:main Sep 3, 2024
8 checks passed
@jmartin-tech jmartin-tech deleted the fix/filter-detector-template branch September 3, 2024 18:50
@github-actions github-actions bot locked and limited conversation to collaborators Sep 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leondz leondz leondz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmartin-tech @leondz