Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
harness: Detector only #833
base: main
Are you sure you want to change the base?
harness: Detector only #833
Changes from 14 commits
d9e7f28
c8b7e77
13c89fe
b87068f
df107c2
d9d43a6
662fbf0
15c1097
3f8e263
4714757
9f63ab1
1b5aa46
239cfc8
65c0c36
e9eb742
a35cb5a
eab5c67
c3d33d4
153ff2e
5086e80
6526194
a7b3e1f
dbe916a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-- out of scope for here, but we should implement serialization/deserialization for
Attempt
sThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this skip the attempt constructor? Can we add an explicit type signature to signal what
cls
is expected to be?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cls
is the callable for theclass
which will be anAttempt
. This will call the__init__()
method with all defaults.Due to the current overrides in the class
attempt_obj.outputs
below may not produce the same in memory object for a multi-turn conversation attempt since the existingas_dict()
method serializedoutputs
into the log and not the full messages history.For the purposes of this PR I suspect this is acceptable, however it is worth noting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if this might shift to a
harness
type options to mimicgenerator_options
andprobe_options
?--harness_options
for inline json--harness_options_file
that could take a json config fileSome validation may be need on the object received to ensure options provided are for a valid harness type and meet the requirements for launching the harness.
This would then remove the need to also add
--probed_report_path
as that is currently only used when this option is set and json or file config aligns with other plugins.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not exactly sure if
continue
orrescore
has been implemented yet (or maybe in some other branch?). But I agree with creatingharness_options
instead of exposing a lot of unnecessary higher-level options. I have incorporated the idea ofharness_options
in the new changes.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By default the detectors to use should probably be extracted from the
start_run setup
entry in the provided report file with the command line option being anoverride
to allow reprocessing results against a different detector.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the refactor for harness selection offered is not used, this needs to be removed as
start_run()
was called before entering this conditional.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this work?