Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't skip listing probes in 100%-pass-rate modules #781

Merged
merged 5 commits into from
Jul 30, 2024

Conversation

leondz
Copy link
Collaborator

@leondz leondz commented Jul 5, 2024

resolves #725

add a constant to control whether or not modules where all probes passed at 100% still include a list of those probes

@leondz leondz added the reporting Reporting, analysis, and other per-run result functions label Jul 5, 2024
Copy link
Collaborator

@jmartin-tech jmartin-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be a configurable option?

As is simply removing the conditional completely would have the same impact as the user cannot control the constant.

garak/analyze/report_digest.py Show resolved Hide resolved
@jmartin-tech jmartin-tech merged commit 9df0d8e into main Jul 30, 2024
10 checks passed
@jmartin-tech jmartin-tech deleted the update/report_dont_skip_100 branch July 30, 2024 16:53
@github-actions github-actions bot locked and limited conversation to collaborators Jul 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
reporting Reporting, analysis, and other per-run result functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

garak.analyze.report_digest html output skips mention of probes used if the module score is 100%
2 participants