Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utilize GarakException in cli #730

Merged

Conversation

jmartin-tech
Copy link
Collaborator

Fix #619

This may not be everything desired in #619, referencing as it mitigates some of the needs there.

  • when a plugin fails to load raise GarakException
  • log the exception trace when error handling in cli

* when a plugin fails to load raise `GarakException`
* log the exception trace when error handling in `cli`

Signed-off-by: Jeffrey Martin <[email protected]>
@jmartin-tech jmartin-tech requested a review from leondz June 6, 2024 21:07
@jmartin-tech jmartin-tech merged commit daf6488 into NVIDIA:main Jun 10, 2024
4 checks passed
@jmartin-tech jmartin-tech deleted the feature/cli-handles-garak-exceptions branch June 10, 2024 14:04
@github-actions github-actions bot locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

skip ctrl-c capture if verbose mode is on
2 participants